Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeSpec Requirement] Only allow suppressions for individual versions #28755

Closed
mikeharder opened this issue Apr 19, 2024 · 1 comment · Fixed by #29001
Closed

[TypeSpec Requirement] Only allow suppressions for individual versions #28755

mikeharder opened this issue Apr 19, 2024 · 1 comment · Fixed by #29001
Assignees
@mikeharder
Labels
Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikeharder
Copy link
Member

mikeharder commented Apr 19, 2024 •
edited

  • Compare path to regex /(preview|stable)/[A-Za-z0-9._-]+/
    • If match, suppression is targeting a single version, and is allowed
    • Else, suppression is too broad, print error message and fail check
# Allowed
- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2022-11-01-preview/**/*.json

# Disallowed
- tool: TypeSpecRequirement
  path: data-plane/**/*.json

Optional improvement: #29000
@mikeharder mikeharder self-assigned this Apr 19, 2024
@konrad-jamrozik
Copy link
Member

This builds on:

@konrad-jamrozik konrad-jamrozik added Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Apr 20, 2024
@mikeharder mikeharder changed the title [TypeSpec Requirement] Add path-based suppression expiration mechanism [TypeSpec Requirement] Only allow suppressions for individual versions May 7, 2024
@mikeharder mikeharder mentioned this issue May 7, 2024
Merged
mikeharder added a commit that referenced this issue May 7, 2024
@mikeharder
[TypeSpecRequirement] Only allow one version per suppression (#29001)
d678044 
- Fixes #28755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeharder mikeharder

Labels
Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TypeSpecRequirement] Only allow one version per suppression mikeharder/azure-rest-api-specs
2 participants
@konrad-jamrozik @mikeharder