Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeSpec Requirement] Add date-based suppression expiration mechanism #28754

Closed
mikeharder opened this issue Apr 19, 2024 · 3 comments
Closed
Assignees
Labels
Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikeharder
Copy link
Member

mikeharder commented Apr 19, 2024

- tool: TypeSpecRequirement
  path: data-plane/**/*.json
  reason: Schedule fully committed until this date
  validThrough: 2024-05-31
  • If currentDate <= validThrough, apply suppression
  • If currentDate > validThrough, print warning and ignore suppression
  • Should validThrough be required or optional?
  • If required, should we enforce a maximum range (e.g. 1 year from currentDate)?
@mikeharder mikeharder self-assigned this Apr 19, 2024
@konrad-jamrozik
Copy link
Member

konrad-jamrozik commented Apr 19, 2024

@rkmanda
Copy link
Member

rkmanda commented Apr 19, 2024

We dont foresee any permanent suppressions for the TypeSpec requirement. So we should make validThrough required and the max range could be 6 months from currentDate

@konrad-jamrozik konrad-jamrozik added Spec PR Tools Tooling that runs in azure-rest-api-specs repo. Central-EngSys This item is owned by the Azure SDK Engineering System team. labels Apr 20, 2024
@mikeharder
Copy link
Member Author

Closing in favor of #28754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This item is owned by the Azure SDK Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 🎊 Closed
Development

No branches or pull requests

3 participants