Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics Combination #4179

Open
2 tasks
Tracked by #3782
NaluTripician opened this issue Nov 8, 2023 · 0 comments · May be fixed by #4175
Open
2 tasks
Tracked by #3782

Diagnostics Combination #4179

NaluTripician opened this issue Nov 8, 2023 · 0 comments · May be fixed by #4175
Labels
feature-request New feature or request

Comments

@NaluTripician
Copy link
Contributor

NaluTripician commented Nov 8, 2023

Diagnostics Combination

This feature will be used in parallel request hedging to combine the diagnostics of all parallel requests made.

Design

To merge diagnostics together we will add a constructor for CosmosTraceDiagnostics that takes in a list of CosmosTraceDiagnostics and merges them into one. This feature will be used for when parallel request hedging is added to the SDK as a way to have the full context for a request that sends out multiple parallel requests.

The Merged Diagnostics will be broken down into the following:

  • A summary of all the requests made + status codes (this exists in the normal diagnostics)
  • A name that will make it clear that this is a multi-request trace + a GUID that wraps all requests
  • Start Time
  • Duration for all requests
  • Data
    • Client configuration
    • Total request charge
  • Children containing full diagnostics strings minus client configuration for each request

Other things that can be added to data

  • All regions contacted
  • Multi Request Trace Reason (Parallel Request Hedging for example)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
1 participant