{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":53971519,"defaultBranch":"master","name":"azure-container-networking","ownerLogin":"Azure","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-03-15T19:12:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6844498?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717470543.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"98ab0591edbb02d483bc7658830703f518c11bf6","ref":"refs/heads/gh-readonly-queue/master/pr-2760-2ab9cfe8236150147b2f551700a9d9e55585f236","pushedAt":"2024-06-04T03:09:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"deps: bump github.com/spf13/viper from 1.18.2 to 1.19.0 (#2760)\n\nBumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.18.2 to 1.19.0.\n- [Release notes](https://github.com/spf13/viper/releases)\n- [Commits](https://github.com/spf13/viper/compare/v1.18.2...v1.19.0)\n\n---\nupdated-dependencies:\n- dependency-name: github.com/spf13/viper\n dependency-type: direct:production\n update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] \nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"deps: bump github.com/spf13/viper from 1.18.2 to 1.19.0 (#2760)"}},{"before":"9d611bd20ca284fcb476d210021330a8a3959038","after":"0e4c01c042a3cae7611a9edbe43afcf6312597d8","ref":"refs/heads/camrynl/bpfimgpipeline","pushedAt":"2024-06-04T00:34:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"manifest build update","shortMessageHtmlLink":"manifest build update"}},{"before":null,"after":"b831ca80fa2251c478b969b323a509e6e856ebeb","ref":"refs/heads/camrynl/skiplogcheck","pushedAt":"2024-06-03T23:56:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"skip check-log-errors","shortMessageHtmlLink":"skip check-log-errors"}},{"before":"993f5910b6abfe7f2542fb6752da9ad01aa71d5d","after":"9d611bd20ca284fcb476d210021330a8a3959038","ref":"refs/heads/camrynl/bpfimgpipeline","pushedAt":"2024-06-03T22:35:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"fix arm build","shortMessageHtmlLink":"fix arm build"}},{"before":"29e3102326f7a92c2f820aea6a5141ebf7f34626","after":"32e149130d4599be47ad3864bdeb70be6f70b837","ref":"refs/heads/singularity/backendinterfaces","pushedAt":"2024-06-03T22:10:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shreyashastantram","name":null,"path":"/shreyashastantram","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105284415?s=80&v=4"},"commit":{"message":"Moving pnpid mapping to swift v2 flow","shortMessageHtmlLink":"Moving pnpid mapping to swift v2 flow"}},{"before":"90f273b9c01531f04ad4c4c0ba7da88a98619bfb","after":"993f5910b6abfe7f2542fb6752da9ad01aa71d5d","ref":"refs/heads/camrynl/bpfimgpipeline","pushedAt":"2024-06-03T20:47:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"split files","shortMessageHtmlLink":"split files"}},{"before":"16ea3131e7a3d5d7fcf5692acc2552c8ab773bc7","after":"d022556498d03a1060b9fbcf42eb7e78beb88b1e","ref":"refs/heads/paul/l1vhcniib","pushedAt":"2024-06-03T20:30:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"paulyufan2","name":"Paul Yu","path":"/paulyufan2","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129891899?s=80&v=4"},"commit":{"message":"fix linter issues","shortMessageHtmlLink":"fix linter issues"}},{"before":"9c19d74f42fff1780bac587b2ef837f2628ad92a","after":"d54f559f92ee7ecc127e9d5764879de4e7347a80","ref":"refs/heads/Kevin-CNS-gRPC","pushedAt":"2024-06-03T20:04:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"Modularized CNS","shortMessageHtmlLink":"Modularized CNS"}},{"before":"1ee2a16faa299a84c820081e7214fa76fad71c79","after":"9c19d74f42fff1780bac587b2ef837f2628ad92a","ref":"refs/heads/Kevin-CNS-gRPC","pushedAt":"2024-06-03T19:53:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"Added dummy methods for PB operatons","shortMessageHtmlLink":"Added dummy methods for PB operatons"}},{"before":"295d657ff96e70abe6ce2b5343f9338330bbb9f8","after":"1ee2a16faa299a84c820081e7214fa76fad71c79","ref":"refs/heads/Kevin-CNS-gRPC","pushedAt":"2024-06-03T19:24:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"Updated .gitignore","shortMessageHtmlLink":"Updated .gitignore"}},{"before":"5213afe0c35939c0011b23206062954309bd318d","after":"295d657ff96e70abe6ce2b5343f9338330bbb9f8","ref":"refs/heads/Kevin-CNS-gRPC","pushedAt":"2024-06-03T19:15:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"Final Commit","shortMessageHtmlLink":"Final Commit"}},{"before":"63382babfb2d5723fac89bd576ee7af41e73b78f","after":"5213afe0c35939c0011b23206062954309bd318d","ref":"refs/heads/Kevin-CNS-gRPC","pushedAt":"2024-06-03T19:14:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"Corrected imports","shortMessageHtmlLink":"Corrected imports"}},{"before":"ab3fabdb2650768bbead36942197de36da7e3796","after":"63382babfb2d5723fac89bd576ee7af41e73b78f","ref":"refs/heads/Kevin-CNS-gRPC","pushedAt":"2024-06-03T19:02:47.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"Resolved merge conflict in Makefile","shortMessageHtmlLink":"Resolved merge conflict in Makefile"}},{"before":"8aab0b3b9077bfa8d475a1ceb3cfeed43a62d2a0","after":"16ea3131e7a3d5d7fcf5692acc2552c8ab773bc7","ref":"refs/heads/paul/l1vhcniib","pushedAt":"2024-06-03T19:01:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"paulyufan2","name":"Paul Yu","path":"/paulyufan2","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129891899?s=80&v=4"},"commit":{"message":"fix UT errors","shortMessageHtmlLink":"fix UT errors"}},{"before":"214427c98a34f2ae5e114ebd8e6eb0bdfeb2db65","after":"ab3fabdb2650768bbead36942197de36da7e3796","ref":"refs/heads/Kevin-CNS-gRPC","pushedAt":"2024-06-03T18:52:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"refactor: code changes for stateless cni and swift v2 (#2688)\n\n* ci: changes up to endpointInternal\n\n* ci: remove defaultInterface from invoker\n\n* ci: change up to CreateEndpoint\n\n* ci: changes up to CreateEndpoint()\n\n* ci: invoker cns and UT fixes\n\n* ci: add fixes to UT(s), capture non populated defaultInterface failures\n\n* ci: multitenancy changes\n\n* ci: invoker azure changes & remove all defaultInterfaceInfo possible\n\n* ci add NICType to baremetal flow\n\n* chore: address comments\n\n* merge nw info fields to ep info and draft new createEndpoint function\n\n* restruct ipamAddResult struct\n\n* reorder code to create epinfo first, and then create network and ep based on epinfo\n\n* add getNwInfo and generate ipamAddResult\n\n* fix network windows.go\n\n* create nw info first and create nw and ep dns info\n\n* fix testIpamAddFail ut referencing wrong redeclared err variable, fix error message\n\n* UT fix part one\n\n* fix the getNetworkID and getNetworkInfo\n\n* move create endpoint to network package, remove ifIndex as needed\n\n* use function to get network id\n\n* unify creation of nw and endpoint info by removing switch\n\n* change functions to consume ep info instead of nw info\n\n* remove unused variable accidentally added earlier\n\n* update old azure ipam invoker to use ep info and change ids to network ids when appropriate\n\npreviously we renamed the NetworkInfo symbol to EndpointInfo in lots of places, but the Id in Network Info is NOT the same as Endpoint Info, so while the code compiles, code that previously used the id field of the network info struct would now be using the id field of the endpoint info struct. It should use the NetworkId field of the endpoint info struct instead.\n\n* rename endpoint info id field to EndpointID to remove ambiguity\n\n* change nw info to ep info in windows\n\n* adjust comments\n\n* move all methods in create ep info dependent on nw info to use ep info instead (windows and linux)\n\naddSubnetToNetworkInfo, setNetworkOptions, and getEndpointPolicies. getEndpointPolicies will now take just the subnets needed as a parameter rather than the whole nw or ep info.\n\n* make cnm compile (not necessarily correct)\n\n* make all tests compile except endpoint test secondary client (windows and linux) (not necessarily correct)\n\n* comment out endpoint test secondary endpoint client case to make tests compile\n\n* address todos and comments from meeting\n\n* remove duplicated code for populating address in ep info generation\n\n* update EndpointCreate to support multiple infra nic\n\n* save all endpoints to state, regardless of type, use either stateless or cni statefile\n\nundos some changes in \"move create endpoint to network package, remove ifIndex as needed\"\ndeletion flow needs to figure out how to tell if the nic type is delegated\n1 interface info : 1 endpoint info : 1 endpoint struct mapping\n\n* fix dual nic support conditional and finding master interface ip\n\nthe master interface ip must be in a particular form where the last few bits are zeroed out based on the mask or we won't find the ip\nfor example, while the host subnet perfix is 10.224.0.113/16, the ip that should be passed into find master interface (subnet) should be 10.224.0.0/16 which matches one of the interfaces' ipnet (10.224.0.0/16)\n\n* fix empty network name\nwhen we need to create a network, we collect the network information, but if we do not find the network, we return an empty nw info and an error\nwhen we create the endpoint we need to use endpoint info's network id, not the (possibly) empty network info struct's network id\n\n* make network_test.go compile (linux and windows compile)\n\nunit tests are not necessarily correct at this point\n\n* add NICType to endpoint struct and populate it\n\nimportant: when getting the endpoint state, the NIC Type field is not populated, leading to deletes not having a NIC Type; this should be changed so that getting the state populates that field\nincluding the nic type allows us to simplify the secondary endpoints delete flow (just check if the nic type is delegated instead of checking if the secondary interfaces map is populated)\n\nsmoke tested:\nlinux aks podsubnet (same vm, multi vm, internet, cni statefile consistent)\nlinux standalone transparent vlan multitenancy (same vm, multi vm, internet, multi vnet, no connection between coke pepsi, cni statefile consistent)\nwindows standalone bridge multitenancy single customer (same vm connections, internet, dns only, cni statefile consistent, 2 pods deleting and recreating)\n\n* ci: InterfaceInfo Map\n\n* fix multitenancy_test ut by changing key\n\n* add endpoint id to secondary ep info test since we populate the id in the actual flow\n\n* fix cni network_test linux and ensure secondary create ep info does not break\n\nin network_test we pass in sample delegated (secondary) data to Add which we then create endpoint info from\neven with most fields empty, in linux, the ep info is created without erroring\n\n* make invoker_cns_test linux pass\n\nrunning all linux package tests for network and cni package pass (or also fail on master, like createBridge)\nwindows unit tests mostly all fail for the same ones on master and this branch\nsummary:\n\t- network_windows_test.go\n\t\t○ TestFailToAddIPv6DefaultRoute already fails on master\n\t- network_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- manager_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- endpoint_windows_test.go\n\t\t○ TestNewAndDeleteEndpointImplHnsV2 already timeouts on master\n\t- endpoint_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- network_windows_test.go\n\t\t○ FAIL: TestPluginSecondAddSamePodWindows/CNI_consecutive_add_already_hot_attached\n\t\t○ FAIL: TestPluginSecondAddSamePodWindows/CNI_consecutive_add_not_hot_attached\n\t\t○ We don't handle consecutive add anymore\n\t- network_test.go\n\t\t○ TestPluginMultitenancyAdd/Add_Happy_path fails on master and my branch (received multiple NC results [] from CNS while dualnic feature is not supported)-- we still get two items on our list/map though which is expected\n\t- invoker_cns_test passes\n\t- invoker_azure_test passes\n - multitenancy_test passes\nThe consecutive add tests fail but that is expected since we no longer support it.\n\n* modify delete flow to handle multiple epinfos to delete\n\ndelete ALL endpoints related to the endpoint infos list in the event cni fails half-way through an add (one failed endpoint create and we delete all would-be-create endpoints and the state)\nreplace looping over deletion code \"n\" number of times with getting a slice of endpoint infos to delete\nmodify stateless cni code to retrieve a slice of network endpoint infos from a single response based on the container id (container id can be used in stateless cni for retrieval)\nincorporate stateless cni changes from other branch (cns client/ipam/restserver changes)\nmodify get endpoint state to return slice of endpoint infos, and getting an endpoint will return an endpoint from that slice with nic type infra\nmove edge case where endpoint is not created in the state but ips are already allocated to immediately after retrieving all ep infos\nfix mock behavior for getting all endpoints by container id\nmove getting network id and network info out of the loop because their values do not seem to change between iterations\nmove deletion of endpoint logic into a dedicated loop, and then create a dedicate loop for calling ipam delete to prevent inconsistent state\n\nall expected unit tests on linux pass\n\n* address feedback\n\n* Make change to UpdateEndpointState API to support SwiftV2 for Stateless CNI\n\n* change save state to only call update endpoint state once with a slice of endpoints, uts pass\n\n* fix using nonexistent key by passing in current interface info directly\n\n* fix azure ipam invoker not getting a populated network info for legacy cni\n\n* add L1VH windows support\n\n* add nic type to windows endpoints\n\n* move adding an external interface code to run only when creating a new network\n\nthis change reflects prior behavior, where we would only add an external interface to the statefile if the network (after searching through all external interfaces) was not found\ncurrently, if there are multiple interfaces that could be selected as the master, we would add each external interface to the statefile, even if the *network* is associated with one of the existing interfaces\nwhile we would still always find the same network (thanks to having a constant NetworkId, regardless of the external interface), you could get an extra empty external interface in your statefile\nthis commit should remove that possibility (the extra external interface shouldn't really matter in the first place though because we always select the external interface that has a matching network created on it)\nthis should be os agnostic\n\n* update comments, first todo check pass\n\n* address some linter issues\n\n* rename networkId to networkID in endpoint info\n\nran package tests in windows and linux for cni and network packages\nran package tests in linux for cns restserver\nall have expected outputs (either pass, or also fails on master branch)\n\n* address linter issues\n\n* preserve more logs and reduce timeout for restart for debugging\n\n* clean comments and rename for clarity\n\nif we use the endpoint info for the network info fields, we name it nwInfo as a hint\n\n* address more linter issues\n\nlinux network, restserver, and cni package tests pass\n\n* Revert \"preserve more logs and reduce timeout for restart for debugging\"\n\nThis reverts commit 0f004925cfb37a4594df63a4259242c37cf07785.\n\n* ignore error on delete flow network query\n\nif we are in stateful cni and do not find the network, we will not error, but when we search for the endpoint it will not be found, leading to us calling ipam invoker delete which is assumed idempotent before returning\npreviously we would error in stateful cni and return before calling ipam invoker delete\n\n* delete network on endpoint delete if stateless and delegated vmnic (win + linux)\n\n* add nic name, set nicname in linux to master interface name\n\nstateless will key into interface map with the nicname field\nin windows, the nicname field is based on the args ifname (usually eth0)\nin linux, the nicname field is based on the master interface found (usually eth0)\n\nnote:\nhostifname/hostvethname = linux veth pair peer in the host ns\nifname/contifname = linux veth pair peer in the container ns, in windows it's just the args ifname\nnicname is something else\nifname isn't used during deletion in linux, hns id is used for deletion in windows\n\n* return secondary interface as cni result if no infra nic found, include mac address in cni result\n\n* address linter issue\n\n* fix critical error where failing to add in windows stateless would lead to hns components not being deleted and add netns for hnsv2\n\ntested by triggering a failure to save the stateless state and seeing that the hns endpoint and network are cleaned up\nwe use the endpoint info to clean up on \"add\" error, but previously, we didn't populate it with the hns ids to do so\n\nadds netns to stateless as the presence of a valid guid in netns determines if hnsv2 is used\n\n* set nicname used in stateless cni according to feedback\n\n* add dummy guid to stateless delete since we assume stateless is always hnsv2\n\nwe assume that the netns value isn't used in stateless deletion\n\n* clean up createEpInfo, declare endpoint info once\n\n* address feedback from vipul\n\n* change comments only\n\n* revert change to cns package\n\n* fix stateless cni migration flow not having nictype on migrate\n\n* keep nwInfo variables named the same as before pr (noop)\n\n* separate endpoint and network policies in endpoint info\n\nbehavior should not change except in hnsv1, where network policies passed into network create call will NOT include endpoint policies\nendpoint policies always include network policies\n\n* address feedback from reviewers\n\n* address feedback and account for case where cns provides info without nic type\n\nif nic type is empty from cns in invoker cns, we assume it is infra nic type and populate it with infra nic type\n\n* address feedback to declare endpoint info once and populate all fields at once\n\nmoved add subnets to after endpoint info created\nmoved retrieval of all endpoint policies (from getEndpointPolicies and getPoliciesFromRuntimeCfg)until after endpoint info created\nnetwork policies are just passed in from the args unaltered\n\n* use ifname instead of nicname field in endpoint struct as key in stateless\n\n* convert macaddress only nictype is delegatedvmnic\n\n* address feedback by removing network dns settings\n\n* address linter issues (noop)\n\n* address feedback and linter (noop)\n\n* remove unused consecutive add funcs (noop)\n\n* fix release ips when create a container without nictype using older cni and then upgrade cni and delete\n\nif we create a pod with an older cni version, it won't have a nictype\nif we upgrade cni and then delete, we should treat an empty nictype as an infra nictype and\ncall the invoker delete\n\n* prevent eps with delegated nic type present on ep from also calling transparent endpoint client on delete\n\ntested on swift v2 linux single pod add, change cni to this version, delete (ok)\nthen add using this cni version and delete, no extraneous transparent endpoint client calls logged\n\n* mock get interface method for ut\n\nsearched for \"NetPlugin\" in all files and determined all prod use of NetPlugin goes through NewNetPlugin where we set the get interface method to the real interface get method\nadds ut where the master interface (by mac) is not found\n\n* address feedback (noop)\n\n* add ut for handling empty nictype on cns add (noop)\n\n* add multitenancy delete net not found ut (noop)\n\n* add uts for multi interface infos single add call, verify endpoint id, cns to cni data conversion and vice versa, get endpoint info from container id (noop)\n\nverifies partial success will delete all endpoints, even successfully created ones in the same cni add call\n\n* add ut for all pods associated with container id delete in one del call, new secondary delete flow (noop)\n\n* add two UTs\n\n* fix a linter issue\n\n* add ut to check endpoint ifname on new endpoint creation based on nictype (noop)\n\n* add ut for fail to find interface by subnet (noop)\n\n* Adding support for Stateless CNI Delete Edge case when there in no HNS ID\n\n* fix uts\n\n* fix linter issues\n\n* fix ut\n\n---------\n\nCo-authored-by: jpayne3506 \nCo-authored-by: paulyufan2 \nCo-authored-by: AzureAhai ","shortMessageHtmlLink":"refactor: code changes for stateless cni and swift v2 (#2688)"}},{"before":"9400ef49971828454e8ea5ab8fb9cf31d1cbec74","after":"8aab0b3b9077bfa8d475a1ceb3cfeed43a62d2a0","ref":"refs/heads/paul/l1vhcniib","pushedAt":"2024-06-03T18:38:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"paulyufan2","name":"Paul Yu","path":"/paulyufan2","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129891899?s=80&v=4"},"commit":{"message":"fix IB issues","shortMessageHtmlLink":"fix IB issues"}},{"before":null,"after":"9400ef49971828454e8ea5ab8fb9cf31d1cbec74","ref":"refs/heads/paul/l1vhcniib","pushedAt":"2024-06-03T15:56:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"paulyufan2","name":"Paul Yu","path":"/paulyufan2","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129891899?s=80&v=4"},"commit":{"message":"add L1VH IB support on CNI","shortMessageHtmlLink":"add L1VH IB support on CNI"}},{"before":"164c3cd8dcc444b6fd8a3e0176c6ab0ea9a363bd","after":"f1b4597b895fa3dbac5d25758d23cac859325e92","ref":"refs/heads/Kevin-Server-Implementation","pushedAt":"2024-06-03T14:16:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Kevincxv","name":"Kevin Camacho","path":"/Kevincxv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/116310689?s=80&v=4"},"commit":{"message":"Revert \"Merge branch 'master' into Kevin-Server-Implementation\"\n\nThis reverts commit 0ff0ec50ca12318c1b37afc5cd9725168956434d, reversing\nchanges made to c8b203e6328632604d6769688b336eacc97d6f08.","shortMessageHtmlLink":"Revert \"Merge branch 'master' into Kevin-Server-Implementation\""}},{"before":null,"after":"c5d9029030d7c38aa49b92735ac16f4811eff17c","ref":"refs/heads/99f4dependabot/go_modules/build/tools/google.golang.org/grpc/cmd/protoc-gen-go-grpc-1.4.0","pushedAt":"2024-06-03T09:41:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"deps: bump google.golang.org/grpc/cmd/protoc-gen-go-grpc in /build/tools\n\nBumps [google.golang.org/grpc/cmd/protoc-gen-go-grpc](https://github.com/grpc/grpc-go) from 1.3.0 to 1.4.0.\n- [Release notes](https://github.com/grpc/grpc-go/releases)\n- [Commits](https://github.com/grpc/grpc-go/compare/v1.3.0...v1.4.0)\n\n---\nupdated-dependencies:\n- dependency-name: google.golang.org/grpc/cmd/protoc-gen-go-grpc\n dependency-type: direct:production\n update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"deps: bump google.golang.org/grpc/cmd/protoc-gen-go-grpc in /build/tools"}},{"before":null,"after":"5cce7c899a23a604d99ba1ea48da5455650fc7bf","ref":"refs/heads/bd63dependabot/go_modules/github.com/spf13/viper-1.19.0","pushedAt":"2024-06-03T09:22:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"deps: bump github.com/spf13/viper from 1.18.2 to 1.19.0\n\nBumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.18.2 to 1.19.0.\n- [Release notes](https://github.com/spf13/viper/releases)\n- [Commits](https://github.com/spf13/viper/compare/v1.18.2...v1.19.0)\n\n---\nupdated-dependencies:\n- dependency-name: github.com/spf13/viper\n dependency-type: direct:production\n update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"deps: bump github.com/spf13/viper from 1.18.2 to 1.19.0"}},{"before":"b8af665be3bec876003cab958c0335c823f49948","after":null,"ref":"refs/heads/alew/merge-structs","pushedAt":"2024-06-01T04:23:35.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"paulyufan2","name":"Paul Yu","path":"/paulyufan2","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129891899?s=80&v=4"}},{"before":"2ab9cfe8236150147b2f551700a9d9e55585f236","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-2688-96a989e078e91f9d64a6b9d3f3892f433d40f605","pushedAt":"2024-06-01T04:23:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"96a989e078e91f9d64a6b9d3f3892f433d40f605","after":"2ab9cfe8236150147b2f551700a9d9e55585f236","ref":"refs/heads/master","pushedAt":"2024-06-01T04:23:33.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"refactor: code changes for stateless cni and swift v2 (#2688)\n\n* ci: changes up to endpointInternal\n\n* ci: remove defaultInterface from invoker\n\n* ci: change up to CreateEndpoint\n\n* ci: changes up to CreateEndpoint()\n\n* ci: invoker cns and UT fixes\n\n* ci: add fixes to UT(s), capture non populated defaultInterface failures\n\n* ci: multitenancy changes\n\n* ci: invoker azure changes & remove all defaultInterfaceInfo possible\n\n* ci add NICType to baremetal flow\n\n* chore: address comments\n\n* merge nw info fields to ep info and draft new createEndpoint function\n\n* restruct ipamAddResult struct\n\n* reorder code to create epinfo first, and then create network and ep based on epinfo\n\n* add getNwInfo and generate ipamAddResult\n\n* fix network windows.go\n\n* create nw info first and create nw and ep dns info\n\n* fix testIpamAddFail ut referencing wrong redeclared err variable, fix error message\n\n* UT fix part one\n\n* fix the getNetworkID and getNetworkInfo\n\n* move create endpoint to network package, remove ifIndex as needed\n\n* use function to get network id\n\n* unify creation of nw and endpoint info by removing switch\n\n* change functions to consume ep info instead of nw info\n\n* remove unused variable accidentally added earlier\n\n* update old azure ipam invoker to use ep info and change ids to network ids when appropriate\n\npreviously we renamed the NetworkInfo symbol to EndpointInfo in lots of places, but the Id in Network Info is NOT the same as Endpoint Info, so while the code compiles, code that previously used the id field of the network info struct would now be using the id field of the endpoint info struct. It should use the NetworkId field of the endpoint info struct instead.\n\n* rename endpoint info id field to EndpointID to remove ambiguity\n\n* change nw info to ep info in windows\n\n* adjust comments\n\n* move all methods in create ep info dependent on nw info to use ep info instead (windows and linux)\n\naddSubnetToNetworkInfo, setNetworkOptions, and getEndpointPolicies. getEndpointPolicies will now take just the subnets needed as a parameter rather than the whole nw or ep info.\n\n* make cnm compile (not necessarily correct)\n\n* make all tests compile except endpoint test secondary client (windows and linux) (not necessarily correct)\n\n* comment out endpoint test secondary endpoint client case to make tests compile\n\n* address todos and comments from meeting\n\n* remove duplicated code for populating address in ep info generation\n\n* update EndpointCreate to support multiple infra nic\n\n* save all endpoints to state, regardless of type, use either stateless or cni statefile\n\nundos some changes in \"move create endpoint to network package, remove ifIndex as needed\"\ndeletion flow needs to figure out how to tell if the nic type is delegated\n1 interface info : 1 endpoint info : 1 endpoint struct mapping\n\n* fix dual nic support conditional and finding master interface ip\n\nthe master interface ip must be in a particular form where the last few bits are zeroed out based on the mask or we won't find the ip\nfor example, while the host subnet perfix is 10.224.0.113/16, the ip that should be passed into find master interface (subnet) should be 10.224.0.0/16 which matches one of the interfaces' ipnet (10.224.0.0/16)\n\n* fix empty network name\nwhen we need to create a network, we collect the network information, but if we do not find the network, we return an empty nw info and an error\nwhen we create the endpoint we need to use endpoint info's network id, not the (possibly) empty network info struct's network id\n\n* make network_test.go compile (linux and windows compile)\n\nunit tests are not necessarily correct at this point\n\n* add NICType to endpoint struct and populate it\n\nimportant: when getting the endpoint state, the NIC Type field is not populated, leading to deletes not having a NIC Type; this should be changed so that getting the state populates that field\nincluding the nic type allows us to simplify the secondary endpoints delete flow (just check if the nic type is delegated instead of checking if the secondary interfaces map is populated)\n\nsmoke tested:\nlinux aks podsubnet (same vm, multi vm, internet, cni statefile consistent)\nlinux standalone transparent vlan multitenancy (same vm, multi vm, internet, multi vnet, no connection between coke pepsi, cni statefile consistent)\nwindows standalone bridge multitenancy single customer (same vm connections, internet, dns only, cni statefile consistent, 2 pods deleting and recreating)\n\n* ci: InterfaceInfo Map\n\n* fix multitenancy_test ut by changing key\n\n* add endpoint id to secondary ep info test since we populate the id in the actual flow\n\n* fix cni network_test linux and ensure secondary create ep info does not break\n\nin network_test we pass in sample delegated (secondary) data to Add which we then create endpoint info from\neven with most fields empty, in linux, the ep info is created without erroring\n\n* make invoker_cns_test linux pass\n\nrunning all linux package tests for network and cni package pass (or also fail on master, like createBridge)\nwindows unit tests mostly all fail for the same ones on master and this branch\nsummary:\n\t- network_windows_test.go\n\t\t○ TestFailToAddIPv6DefaultRoute already fails on master\n\t- network_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- manager_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- endpoint_windows_test.go\n\t\t○ TestNewAndDeleteEndpointImplHnsV2 already timeouts on master\n\t- endpoint_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- network_windows_test.go\n\t\t○ FAIL: TestPluginSecondAddSamePodWindows/CNI_consecutive_add_already_hot_attached\n\t\t○ FAIL: TestPluginSecondAddSamePodWindows/CNI_consecutive_add_not_hot_attached\n\t\t○ We don't handle consecutive add anymore\n\t- network_test.go\n\t\t○ TestPluginMultitenancyAdd/Add_Happy_path fails on master and my branch (received multiple NC results [] from CNS while dualnic feature is not supported)-- we still get two items on our list/map though which is expected\n\t- invoker_cns_test passes\n\t- invoker_azure_test passes\n - multitenancy_test passes\nThe consecutive add tests fail but that is expected since we no longer support it.\n\n* modify delete flow to handle multiple epinfos to delete\n\ndelete ALL endpoints related to the endpoint infos list in the event cni fails half-way through an add (one failed endpoint create and we delete all would-be-create endpoints and the state)\nreplace looping over deletion code \"n\" number of times with getting a slice of endpoint infos to delete\nmodify stateless cni code to retrieve a slice of network endpoint infos from a single response based on the container id (container id can be used in stateless cni for retrieval)\nincorporate stateless cni changes from other branch (cns client/ipam/restserver changes)\nmodify get endpoint state to return slice of endpoint infos, and getting an endpoint will return an endpoint from that slice with nic type infra\nmove edge case where endpoint is not created in the state but ips are already allocated to immediately after retrieving all ep infos\nfix mock behavior for getting all endpoints by container id\nmove getting network id and network info out of the loop because their values do not seem to change between iterations\nmove deletion of endpoint logic into a dedicated loop, and then create a dedicate loop for calling ipam delete to prevent inconsistent state\n\nall expected unit tests on linux pass\n\n* address feedback\n\n* Make change to UpdateEndpointState API to support SwiftV2 for Stateless CNI\n\n* change save state to only call update endpoint state once with a slice of endpoints, uts pass\n\n* fix using nonexistent key by passing in current interface info directly\n\n* fix azure ipam invoker not getting a populated network info for legacy cni\n\n* add L1VH windows support\n\n* add nic type to windows endpoints\n\n* move adding an external interface code to run only when creating a new network\n\nthis change reflects prior behavior, where we would only add an external interface to the statefile if the network (after searching through all external interfaces) was not found\ncurrently, if there are multiple interfaces that could be selected as the master, we would add each external interface to the statefile, even if the *network* is associated with one of the existing interfaces\nwhile we would still always find the same network (thanks to having a constant NetworkId, regardless of the external interface), you could get an extra empty external interface in your statefile\nthis commit should remove that possibility (the extra external interface shouldn't really matter in the first place though because we always select the external interface that has a matching network created on it)\nthis should be os agnostic\n\n* update comments, first todo check pass\n\n* address some linter issues\n\n* rename networkId to networkID in endpoint info\n\nran package tests in windows and linux for cni and network packages\nran package tests in linux for cns restserver\nall have expected outputs (either pass, or also fails on master branch)\n\n* address linter issues\n\n* preserve more logs and reduce timeout for restart for debugging\n\n* clean comments and rename for clarity\n\nif we use the endpoint info for the network info fields, we name it nwInfo as a hint\n\n* address more linter issues\n\nlinux network, restserver, and cni package tests pass\n\n* Revert \"preserve more logs and reduce timeout for restart for debugging\"\n\nThis reverts commit 0f004925cfb37a4594df63a4259242c37cf07785.\n\n* ignore error on delete flow network query\n\nif we are in stateful cni and do not find the network, we will not error, but when we search for the endpoint it will not be found, leading to us calling ipam invoker delete which is assumed idempotent before returning\npreviously we would error in stateful cni and return before calling ipam invoker delete\n\n* delete network on endpoint delete if stateless and delegated vmnic (win + linux)\n\n* add nic name, set nicname in linux to master interface name\n\nstateless will key into interface map with the nicname field\nin windows, the nicname field is based on the args ifname (usually eth0)\nin linux, the nicname field is based on the master interface found (usually eth0)\n\nnote:\nhostifname/hostvethname = linux veth pair peer in the host ns\nifname/contifname = linux veth pair peer in the container ns, in windows it's just the args ifname\nnicname is something else\nifname isn't used during deletion in linux, hns id is used for deletion in windows\n\n* return secondary interface as cni result if no infra nic found, include mac address in cni result\n\n* address linter issue\n\n* fix critical error where failing to add in windows stateless would lead to hns components not being deleted and add netns for hnsv2\n\ntested by triggering a failure to save the stateless state and seeing that the hns endpoint and network are cleaned up\nwe use the endpoint info to clean up on \"add\" error, but previously, we didn't populate it with the hns ids to do so\n\nadds netns to stateless as the presence of a valid guid in netns determines if hnsv2 is used\n\n* set nicname used in stateless cni according to feedback\n\n* add dummy guid to stateless delete since we assume stateless is always hnsv2\n\nwe assume that the netns value isn't used in stateless deletion\n\n* clean up createEpInfo, declare endpoint info once\n\n* address feedback from vipul\n\n* change comments only\n\n* revert change to cns package\n\n* fix stateless cni migration flow not having nictype on migrate\n\n* keep nwInfo variables named the same as before pr (noop)\n\n* separate endpoint and network policies in endpoint info\n\nbehavior should not change except in hnsv1, where network policies passed into network create call will NOT include endpoint policies\nendpoint policies always include network policies\n\n* address feedback from reviewers\n\n* address feedback and account for case where cns provides info without nic type\n\nif nic type is empty from cns in invoker cns, we assume it is infra nic type and populate it with infra nic type\n\n* address feedback to declare endpoint info once and populate all fields at once\n\nmoved add subnets to after endpoint info created\nmoved retrieval of all endpoint policies (from getEndpointPolicies and getPoliciesFromRuntimeCfg)until after endpoint info created\nnetwork policies are just passed in from the args unaltered\n\n* use ifname instead of nicname field in endpoint struct as key in stateless\n\n* convert macaddress only nictype is delegatedvmnic\n\n* address feedback by removing network dns settings\n\n* address linter issues (noop)\n\n* address feedback and linter (noop)\n\n* remove unused consecutive add funcs (noop)\n\n* fix release ips when create a container without nictype using older cni and then upgrade cni and delete\n\nif we create a pod with an older cni version, it won't have a nictype\nif we upgrade cni and then delete, we should treat an empty nictype as an infra nictype and\ncall the invoker delete\n\n* prevent eps with delegated nic type present on ep from also calling transparent endpoint client on delete\n\ntested on swift v2 linux single pod add, change cni to this version, delete (ok)\nthen add using this cni version and delete, no extraneous transparent endpoint client calls logged\n\n* mock get interface method for ut\n\nsearched for \"NetPlugin\" in all files and determined all prod use of NetPlugin goes through NewNetPlugin where we set the get interface method to the real interface get method\nadds ut where the master interface (by mac) is not found\n\n* address feedback (noop)\n\n* add ut for handling empty nictype on cns add (noop)\n\n* add multitenancy delete net not found ut (noop)\n\n* add uts for multi interface infos single add call, verify endpoint id, cns to cni data conversion and vice versa, get endpoint info from container id (noop)\n\nverifies partial success will delete all endpoints, even successfully created ones in the same cni add call\n\n* add ut for all pods associated with container id delete in one del call, new secondary delete flow (noop)\n\n* add two UTs\n\n* fix a linter issue\n\n* add ut to check endpoint ifname on new endpoint creation based on nictype (noop)\n\n* add ut for fail to find interface by subnet (noop)\n\n* Adding support for Stateless CNI Delete Edge case when there in no HNS ID\n\n* fix uts\n\n* fix linter issues\n\n* fix ut\n\n---------\n\nCo-authored-by: jpayne3506 \nCo-authored-by: paulyufan2 \nCo-authored-by: AzureAhai ","shortMessageHtmlLink":"refactor: code changes for stateless cni and swift v2 (#2688)"}},{"before":null,"after":"2ab9cfe8236150147b2f551700a9d9e55585f236","ref":"refs/heads/gh-readonly-queue/master/pr-2688-96a989e078e91f9d64a6b9d3f3892f433d40f605","pushedAt":"2024-06-01T01:36:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"refactor: code changes for stateless cni and swift v2 (#2688)\n\n* ci: changes up to endpointInternal\n\n* ci: remove defaultInterface from invoker\n\n* ci: change up to CreateEndpoint\n\n* ci: changes up to CreateEndpoint()\n\n* ci: invoker cns and UT fixes\n\n* ci: add fixes to UT(s), capture non populated defaultInterface failures\n\n* ci: multitenancy changes\n\n* ci: invoker azure changes & remove all defaultInterfaceInfo possible\n\n* ci add NICType to baremetal flow\n\n* chore: address comments\n\n* merge nw info fields to ep info and draft new createEndpoint function\n\n* restruct ipamAddResult struct\n\n* reorder code to create epinfo first, and then create network and ep based on epinfo\n\n* add getNwInfo and generate ipamAddResult\n\n* fix network windows.go\n\n* create nw info first and create nw and ep dns info\n\n* fix testIpamAddFail ut referencing wrong redeclared err variable, fix error message\n\n* UT fix part one\n\n* fix the getNetworkID and getNetworkInfo\n\n* move create endpoint to network package, remove ifIndex as needed\n\n* use function to get network id\n\n* unify creation of nw and endpoint info by removing switch\n\n* change functions to consume ep info instead of nw info\n\n* remove unused variable accidentally added earlier\n\n* update old azure ipam invoker to use ep info and change ids to network ids when appropriate\n\npreviously we renamed the NetworkInfo symbol to EndpointInfo in lots of places, but the Id in Network Info is NOT the same as Endpoint Info, so while the code compiles, code that previously used the id field of the network info struct would now be using the id field of the endpoint info struct. It should use the NetworkId field of the endpoint info struct instead.\n\n* rename endpoint info id field to EndpointID to remove ambiguity\n\n* change nw info to ep info in windows\n\n* adjust comments\n\n* move all methods in create ep info dependent on nw info to use ep info instead (windows and linux)\n\naddSubnetToNetworkInfo, setNetworkOptions, and getEndpointPolicies. getEndpointPolicies will now take just the subnets needed as a parameter rather than the whole nw or ep info.\n\n* make cnm compile (not necessarily correct)\n\n* make all tests compile except endpoint test secondary client (windows and linux) (not necessarily correct)\n\n* comment out endpoint test secondary endpoint client case to make tests compile\n\n* address todos and comments from meeting\n\n* remove duplicated code for populating address in ep info generation\n\n* update EndpointCreate to support multiple infra nic\n\n* save all endpoints to state, regardless of type, use either stateless or cni statefile\n\nundos some changes in \"move create endpoint to network package, remove ifIndex as needed\"\ndeletion flow needs to figure out how to tell if the nic type is delegated\n1 interface info : 1 endpoint info : 1 endpoint struct mapping\n\n* fix dual nic support conditional and finding master interface ip\n\nthe master interface ip must be in a particular form where the last few bits are zeroed out based on the mask or we won't find the ip\nfor example, while the host subnet perfix is 10.224.0.113/16, the ip that should be passed into find master interface (subnet) should be 10.224.0.0/16 which matches one of the interfaces' ipnet (10.224.0.0/16)\n\n* fix empty network name\nwhen we need to create a network, we collect the network information, but if we do not find the network, we return an empty nw info and an error\nwhen we create the endpoint we need to use endpoint info's network id, not the (possibly) empty network info struct's network id\n\n* make network_test.go compile (linux and windows compile)\n\nunit tests are not necessarily correct at this point\n\n* add NICType to endpoint struct and populate it\n\nimportant: when getting the endpoint state, the NIC Type field is not populated, leading to deletes not having a NIC Type; this should be changed so that getting the state populates that field\nincluding the nic type allows us to simplify the secondary endpoints delete flow (just check if the nic type is delegated instead of checking if the secondary interfaces map is populated)\n\nsmoke tested:\nlinux aks podsubnet (same vm, multi vm, internet, cni statefile consistent)\nlinux standalone transparent vlan multitenancy (same vm, multi vm, internet, multi vnet, no connection between coke pepsi, cni statefile consistent)\nwindows standalone bridge multitenancy single customer (same vm connections, internet, dns only, cni statefile consistent, 2 pods deleting and recreating)\n\n* ci: InterfaceInfo Map\n\n* fix multitenancy_test ut by changing key\n\n* add endpoint id to secondary ep info test since we populate the id in the actual flow\n\n* fix cni network_test linux and ensure secondary create ep info does not break\n\nin network_test we pass in sample delegated (secondary) data to Add which we then create endpoint info from\neven with most fields empty, in linux, the ep info is created without erroring\n\n* make invoker_cns_test linux pass\n\nrunning all linux package tests for network and cni package pass (or also fail on master, like createBridge)\nwindows unit tests mostly all fail for the same ones on master and this branch\nsummary:\n\t- network_windows_test.go\n\t\t○ TestFailToAddIPv6DefaultRoute already fails on master\n\t- network_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- manager_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- endpoint_windows_test.go\n\t\t○ TestNewAndDeleteEndpointImplHnsV2 already timeouts on master\n\t- endpoint_test.go\n\t\t○ 9 tests fail on master, 9 tests fail on my branch\n\t- network_windows_test.go\n\t\t○ FAIL: TestPluginSecondAddSamePodWindows/CNI_consecutive_add_already_hot_attached\n\t\t○ FAIL: TestPluginSecondAddSamePodWindows/CNI_consecutive_add_not_hot_attached\n\t\t○ We don't handle consecutive add anymore\n\t- network_test.go\n\t\t○ TestPluginMultitenancyAdd/Add_Happy_path fails on master and my branch (received multiple NC results [] from CNS while dualnic feature is not supported)-- we still get two items on our list/map though which is expected\n\t- invoker_cns_test passes\n\t- invoker_azure_test passes\n - multitenancy_test passes\nThe consecutive add tests fail but that is expected since we no longer support it.\n\n* modify delete flow to handle multiple epinfos to delete\n\ndelete ALL endpoints related to the endpoint infos list in the event cni fails half-way through an add (one failed endpoint create and we delete all would-be-create endpoints and the state)\nreplace looping over deletion code \"n\" number of times with getting a slice of endpoint infos to delete\nmodify stateless cni code to retrieve a slice of network endpoint infos from a single response based on the container id (container id can be used in stateless cni for retrieval)\nincorporate stateless cni changes from other branch (cns client/ipam/restserver changes)\nmodify get endpoint state to return slice of endpoint infos, and getting an endpoint will return an endpoint from that slice with nic type infra\nmove edge case where endpoint is not created in the state but ips are already allocated to immediately after retrieving all ep infos\nfix mock behavior for getting all endpoints by container id\nmove getting network id and network info out of the loop because their values do not seem to change between iterations\nmove deletion of endpoint logic into a dedicated loop, and then create a dedicate loop for calling ipam delete to prevent inconsistent state\n\nall expected unit tests on linux pass\n\n* address feedback\n\n* Make change to UpdateEndpointState API to support SwiftV2 for Stateless CNI\n\n* change save state to only call update endpoint state once with a slice of endpoints, uts pass\n\n* fix using nonexistent key by passing in current interface info directly\n\n* fix azure ipam invoker not getting a populated network info for legacy cni\n\n* add L1VH windows support\n\n* add nic type to windows endpoints\n\n* move adding an external interface code to run only when creating a new network\n\nthis change reflects prior behavior, where we would only add an external interface to the statefile if the network (after searching through all external interfaces) was not found\ncurrently, if there are multiple interfaces that could be selected as the master, we would add each external interface to the statefile, even if the *network* is associated with one of the existing interfaces\nwhile we would still always find the same network (thanks to having a constant NetworkId, regardless of the external interface), you could get an extra empty external interface in your statefile\nthis commit should remove that possibility (the extra external interface shouldn't really matter in the first place though because we always select the external interface that has a matching network created on it)\nthis should be os agnostic\n\n* update comments, first todo check pass\n\n* address some linter issues\n\n* rename networkId to networkID in endpoint info\n\nran package tests in windows and linux for cni and network packages\nran package tests in linux for cns restserver\nall have expected outputs (either pass, or also fails on master branch)\n\n* address linter issues\n\n* preserve more logs and reduce timeout for restart for debugging\n\n* clean comments and rename for clarity\n\nif we use the endpoint info for the network info fields, we name it nwInfo as a hint\n\n* address more linter issues\n\nlinux network, restserver, and cni package tests pass\n\n* Revert \"preserve more logs and reduce timeout for restart for debugging\"\n\nThis reverts commit 0f004925cfb37a4594df63a4259242c37cf07785.\n\n* ignore error on delete flow network query\n\nif we are in stateful cni and do not find the network, we will not error, but when we search for the endpoint it will not be found, leading to us calling ipam invoker delete which is assumed idempotent before returning\npreviously we would error in stateful cni and return before calling ipam invoker delete\n\n* delete network on endpoint delete if stateless and delegated vmnic (win + linux)\n\n* add nic name, set nicname in linux to master interface name\n\nstateless will key into interface map with the nicname field\nin windows, the nicname field is based on the args ifname (usually eth0)\nin linux, the nicname field is based on the master interface found (usually eth0)\n\nnote:\nhostifname/hostvethname = linux veth pair peer in the host ns\nifname/contifname = linux veth pair peer in the container ns, in windows it's just the args ifname\nnicname is something else\nifname isn't used during deletion in linux, hns id is used for deletion in windows\n\n* return secondary interface as cni result if no infra nic found, include mac address in cni result\n\n* address linter issue\n\n* fix critical error where failing to add in windows stateless would lead to hns components not being deleted and add netns for hnsv2\n\ntested by triggering a failure to save the stateless state and seeing that the hns endpoint and network are cleaned up\nwe use the endpoint info to clean up on \"add\" error, but previously, we didn't populate it with the hns ids to do so\n\nadds netns to stateless as the presence of a valid guid in netns determines if hnsv2 is used\n\n* set nicname used in stateless cni according to feedback\n\n* add dummy guid to stateless delete since we assume stateless is always hnsv2\n\nwe assume that the netns value isn't used in stateless deletion\n\n* clean up createEpInfo, declare endpoint info once\n\n* address feedback from vipul\n\n* change comments only\n\n* revert change to cns package\n\n* fix stateless cni migration flow not having nictype on migrate\n\n* keep nwInfo variables named the same as before pr (noop)\n\n* separate endpoint and network policies in endpoint info\n\nbehavior should not change except in hnsv1, where network policies passed into network create call will NOT include endpoint policies\nendpoint policies always include network policies\n\n* address feedback from reviewers\n\n* address feedback and account for case where cns provides info without nic type\n\nif nic type is empty from cns in invoker cns, we assume it is infra nic type and populate it with infra nic type\n\n* address feedback to declare endpoint info once and populate all fields at once\n\nmoved add subnets to after endpoint info created\nmoved retrieval of all endpoint policies (from getEndpointPolicies and getPoliciesFromRuntimeCfg)until after endpoint info created\nnetwork policies are just passed in from the args unaltered\n\n* use ifname instead of nicname field in endpoint struct as key in stateless\n\n* convert macaddress only nictype is delegatedvmnic\n\n* address feedback by removing network dns settings\n\n* address linter issues (noop)\n\n* address feedback and linter (noop)\n\n* remove unused consecutive add funcs (noop)\n\n* fix release ips when create a container without nictype using older cni and then upgrade cni and delete\n\nif we create a pod with an older cni version, it won't have a nictype\nif we upgrade cni and then delete, we should treat an empty nictype as an infra nictype and\ncall the invoker delete\n\n* prevent eps with delegated nic type present on ep from also calling transparent endpoint client on delete\n\ntested on swift v2 linux single pod add, change cni to this version, delete (ok)\nthen add using this cni version and delete, no extraneous transparent endpoint client calls logged\n\n* mock get interface method for ut\n\nsearched for \"NetPlugin\" in all files and determined all prod use of NetPlugin goes through NewNetPlugin where we set the get interface method to the real interface get method\nadds ut where the master interface (by mac) is not found\n\n* address feedback (noop)\n\n* add ut for handling empty nictype on cns add (noop)\n\n* add multitenancy delete net not found ut (noop)\n\n* add uts for multi interface infos single add call, verify endpoint id, cns to cni data conversion and vice versa, get endpoint info from container id (noop)\n\nverifies partial success will delete all endpoints, even successfully created ones in the same cni add call\n\n* add ut for all pods associated with container id delete in one del call, new secondary delete flow (noop)\n\n* add two UTs\n\n* fix a linter issue\n\n* add ut to check endpoint ifname on new endpoint creation based on nictype (noop)\n\n* add ut for fail to find interface by subnet (noop)\n\n* Adding support for Stateless CNI Delete Edge case when there in no HNS ID\n\n* fix uts\n\n* fix linter issues\n\n* fix ut\n\n---------\n\nCo-authored-by: jpayne3506 \nCo-authored-by: paulyufan2 \nCo-authored-by: AzureAhai ","shortMessageHtmlLink":"refactor: code changes for stateless cni and swift v2 (#2688)"}},{"before":"a4759bceaaa6bea0995198fdcbe1b65c0d1c79dd","after":"90f273b9c01531f04ad4c4c0ba7da88a98619bfb","ref":"refs/heads/camrynl/bpfimgpipeline","pushedAt":"2024-05-31T23:40:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"reorder","shortMessageHtmlLink":"reorder"}},{"before":"93b64aed02528a08810a6d22a93b24fac7d93567","after":"a4759bceaaa6bea0995198fdcbe1b65c0d1c79dd","ref":"refs/heads/camrynl/bpfimgpipeline","pushedAt":"2024-05-31T23:02:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"change final stage","shortMessageHtmlLink":"change final stage"}},{"before":"7e2551b30dff277cc263d9d312de34d1f9ca03bd","after":"93b64aed02528a08810a6d22a93b24fac7d93567","ref":"refs/heads/camrynl/bpfimgpipeline","pushedAt":"2024-05-31T22:24:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"minimize img","shortMessageHtmlLink":"minimize img"}},{"before":"3855d4fafa2f336151ff3f52a37dae21594930ac","after":"7e2551b30dff277cc263d9d312de34d1f9ca03bd","ref":"refs/heads/camrynl/bpfimgpipeline","pushedAt":"2024-05-31T21:19:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"camrynl","name":"Camryn Lee","path":"/camrynl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31013536?s=80&v=4"},"commit":{"message":"arch changes","shortMessageHtmlLink":"arch changes"}},{"before":"87aefd048771fdb9059ef12d9d423cea880cbf8d","after":"b8af665be3bec876003cab958c0335c823f49948","ref":"refs/heads/alew/merge-structs","pushedAt":"2024-05-31T20:56:36.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"QxBytes","name":null,"path":"/QxBytes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39818795?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/master' into alew/merge-structs","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/master' into alew/merge-structs"}},{"before":"ff234e9e12d9aedd70d25a3c9bb27ba186633ebb","after":"87aefd048771fdb9059ef12d9d423cea880cbf8d","ref":"refs/heads/alew/merge-structs","pushedAt":"2024-05-31T20:36:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"QxBytes","name":null,"path":"/QxBytes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39818795?s=80&v=4"},"commit":{"message":"fix ut","shortMessageHtmlLink":"fix ut"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEW5AwigA","startCursor":null,"endCursor":null}},"title":"Activity · Azure/azure-container-networking"}