New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Multipart input model logic in emitter and autorest.csharp after adopt tcgc getAllModels #4664

Open

Tracked by

chunyu3 opened this issue Apr 26, 2024 · 0 comments

Assignees

Labels

DPG

Member

chunyu3 commented Apr 26, 2024

After adopt tcgc getAllModels which will calculate Multipart Usage for models, we will remove current logic:

Remove Multipart Usage calculate logic in emitter:

autorest.csharp/src/TypeSpec.Extension/Emitter.Csharp/src/lib/clientModelBuilder.ts

Line 166 in dac2fba

/* TODO: remove this when adopt tcgc.
Move the File type converter for bytes to emitter:

autorest.csharp/src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputModelTypeConverter.cs

Line 135 in dac2fba

/* TODO: in Multipart body model, if the property is of type Bytes, it should be converted to Stream

chunyu3 self-assigned this

chunyu3 added the DPG label

chunyu3 mentioned this issue

[Epic] Multipart/form-data support #4337

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment