Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http-client-csharp): remove setters for model properties collection types #3233

Merged
merged 5 commits into from Apr 29, 2024

Conversation

jorgerangel-msft
Copy link
Contributor

This PR fixes the case where setters were being generated for model properties that were collection types. Model properties that are collection types will no longer generated a setter unless they are nullable.

@jorgerangel-msft jorgerangel-msft changed the title fix: remove setters for model properties collection types fix(http-client-csharp): remove setters for model properties collection types Apr 24, 2024
@jorgerangel-msft jorgerangel-msft marked this pull request as ready for review April 24, 2024 20:43
…rp/src/Models/Types/ModelTypeProvider.cs

Co-authored-by: Dapeng Zhang <ufo54153@gmail.com>
@jorgerangel-msft jorgerangel-msft added this pull request to the merge queue Apr 29, 2024
Merged via the queue into microsoft:main with commit d3a4454 Apr 29, 2024
19 checks passed
@jorgerangel-msft jorgerangel-msft deleted the collection-props branch April 29, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Microsoft Generator CSharp] Exclude Setter Generation for Collection Properties
3 participants