Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPG][.Net] Unexpected diff for CognitiveSearch test project #4605

Closed
live1206 opened this issue Apr 19, 2024 · 2 comments · Fixed by #4685
Closed

[MPG][.Net] Unexpected diff for CognitiveSearch test project #4605

live1206 opened this issue Apr 19, 2024 · 2 comments · Fixed by #4685
Assignees
@live1206
Labels
Mgmt This issue is related to a management-plane library. v3 Version 3 of AutoRest C# generator.

Comments

@live1206
Copy link
Member

live1206 commented Apr 19, 2024 •
edited

There is no InputPrimitiveType to represent char, it maps to string instead

Corresponding declaration in swagger:
https://github.com/Azure/azure-rest-api-specs/blob/e606243e5297312781dd7dbfd7ab76d2329cc088/specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchservice.json#L3138-L3143
@live1206 live1206 added the v3 Version 3 of AutoRest C# generator. label Apr 19, 2024
@live1206 live1206 self-assigned this Apr 19, 2024
@live1206 live1206 mentioned this issue Apr 19, 2024
Open
9 tasks
@live1206 live1206 added the Mgmt This issue is related to a management-plane library. label Apr 19, 2024
@live1206
Copy link
Member Author

this might depend on the generic representation of decorator in codemodel.json work

@live1206
Copy link
Member Author

Regardless typeSpec will support char as first-class type or not, I think we should add InputPrimitiveType.Char to represent CSharpType char in the .NET generator.

@live1206 live1206 mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@live1206 live1206

Labels
Mgmt This issue is related to a management-plane library. v3 Version 3 of AutoRest C# generator.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add char InputTypeKind live1206/autorest.csharp
1 participant
@live1206