Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator]: do not keep a class under Azure.Core namespace even if its accessibility is internal #4597

Open
archerzz opened this issue Apr 18, 2024 · 0 comments
Assignees
Labels

Comments

@archerzz
Copy link
Member

Description

communication/Communication.JobRouter has marked some operations internal: https://github.com/Azure/azure-rest-api-specs/blob/c4e661cdf92c8f579574008d0cd11874cc303da0/specification/communication/Communication.JobRouter/client.tsp#L25

Thus, the accessibility of some foundation models are marked as internal.
image

In current implementation, we'll keep a model as long as its accessibility is set. I think we should not keep any foundation model, no matter what the accessibility is. If it's really used, it should be referenced from Azure.Core, not from our generated codes.

archerzz added a commit to archerzz/autorest.csharp that referenced this issue Apr 18, 2024
Even the accessibility is set, we should not keep them since they should be referenced from Azure.Core

resovle Azure#4597
archerzz added a commit to archerzz/autorest.csharp that referenced this issue Apr 18, 2024
Even the accessibility is set, we should not keep them since they should be referenced from Azure.Core

resovle Azure#4597
@archerzz archerzz self-assigned this Apr 19, 2024
@archerzz archerzz added the DPG label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant