Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through ModelReaderWriter options to SerializationHooks #4665

Merged
merged 2 commits into from May 10, 2024
Merged

Pass through ModelReaderWriter options to SerializationHooks #4665

merged 2 commits into from May 10, 2024

Conversation

nisha-bhatia
Copy link
Member

@nisha-bhatia nisha-bhatia commented Apr 26, 2024 •
edited by ArcturusZhang

Resolves #4594

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@nisha-bhatia nisha-bhatia self-assigned this Apr 26, 2024
@nisha-bhatia
Copy link
Member Author

Resolves: #4594

This was referenced May 9, 2024
Draft
Draft
Draft
@nisha-bhatia nisha-bhatia force-pushed the nibhati-addOptions branch 2 times, most recently from c2c3b5d to cbadf00 Compare May 10, 2024 18:51
@azure-sdk azure-sdk mentioned this pull request May 10, 2024
Draft
@nisha-bhatia nisha-bhatia merged commit 213b563 into Azure:feature/v3 May 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-nash m-nash m-nash approved these changes

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees

@nisha-bhatia nisha-bhatia

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nisha-bhatia @m-nash