Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine mgmt reference type #4663

Merged
merged 25 commits into from May 10, 2024
Merged

Refine mgmt reference type #4663

merged 25 commits into from May 10, 2024

Conversation

live1206
Copy link
Member

@live1206 live1206 commented Apr 26, 2024 •
edited

Resolves #4590

  • Maintain list of type names for PropertyReferenceType and TypeReferenceType and ReferenceType
    • For ReferenceType, it is abstract and there is no serialization for it since it is abstract
  • Remove test project MgmtReferenceTypes because we can't have the same namespace and type names as Azure.ResourceManager is referenced in the test projects
  • We can remove the custom code of ResourceData and TrackedResourceData after this

@live1206 live1206 added the Mgmt This issue is related to a management-plane library. label Apr 26, 2024
@azure-sdk azure-sdk mentioned this pull request Apr 26, 2024
Closed
@azure-sdk azure-sdk mentioned this pull request Apr 28, 2024
Closed
@azure-sdk azure-sdk mentioned this pull request Apr 28, 2024
Closed
@azure-sdk azure-sdk mentioned this pull request Apr 28, 2024
Closed
@live1206 live1206 marked this pull request as ready for review May 8, 2024 03:15
@azure-sdk azure-sdk mentioned this pull request May 8, 2024
Draft
@live1206 live1206 enabled auto-merge (squash) May 10, 2024 01:43
@live1206 live1206 merged commit b2aadea into Azure:feature/v3 May 10, 2024
8 checks passed
@live1206 live1206 deleted the refine-mgmt-reference-type branch May 11, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MPG][.Net] Unexpected diff for MgmtReferenceTypes test project
3 participants
@live1206 @ArcturusZhang @ArthurMa1978