Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byo subnets #183

Closed
wants to merge 10 commits into from
Closed

Byo subnets #183

wants to merge 10 commits into from

Conversation

ChrisLopezUK
Copy link

Fixes #182

@ChrisLopezUK
Copy link
Author

There is one thing that this PR doesn't fix, that I had hoped it would.

Although it allows you to choose your own subnets for each item, it doesn't allow you to define a single subnet for Web, Redis, San, Tika, Elastic (AppGW and Vnet GW always need their own). This would be useful for testing scenarios, scenarios where your segregation is taken care of via a Virtual Firewall, or scenarios where you are restricted on subnets

I welcome any feedback on how to achieve this part.

@ChrisLopezUK
Copy link
Author

Going to pull this one back as I did some work later that improved this a lot.

@ChrisLopezUK ChrisLopezUK deleted the byoSubnets branch October 30, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Custom Subnets
1 participant