Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend crash due to invalid citations #707

Open
cecheta opened this issue Apr 18, 2024 · 0 comments
Open

Frontend crash due to invalid citations #707

cecheta opened this issue Apr 18, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cecheta
Copy link
Collaborator

cecheta commented Apr 18, 2024

Describe the bug

The frontend crashed after receiving a response from the /custom endpoint. I was not able to obtain the response, however the crash occurred at this line, as citation was undefined:

citation.id = citationIndex; // original doc index to de-dupe

The error most likely occurred because the response contained a citation that did not exist, i.e. [doc6], even though there were only 5 source documents.

The following was observed in the API logs:

Source document 6 not provided, skipping doc
Source document 7 not provided, skipping doc
Source document 8 not provided, skipping doc
Source document 9 not provided, skipping doc

Expected behavior

The frontend application should not crash. Errors should be caught and an handled gracefully, or an appropriate error is returned to the user.


Debugging information

Steps to reproduce

Difficult to reproduce due to non-deterministic result.

Logs

Provided above.


Tasks

To be filled in by the engineer picking up the issue

@cecheta cecheta added the bug Something isn't working label Apr 18, 2024
@komalg1 komalg1 self-assigned this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants