-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of a processing group's type through the annotation. #2788
Comments
Although I get where this is coming from, I don't think we should expand the The Processing Group should not dictate the configuration of the Event Processor since the control is the other way around. The referred to "type" is the type of the Event Processor. Not the type of the Processing Group. Secondly, I think the most straightforward way to support your suggestion would be for the Granted, I believe there'd be a way to have the plain Java configuration (that reads the So, that's my two cents, @vab2048. |
ah... that makes things complicated! my use case was for a pet project where I receive price data for a market. I want a number of views in the command model to be in-memory and making it explicit on the class for the event handlers itself would have been better (in my opinion) than in a properties file or specific java config file. I'll leave it to you if you think this idea (some mechanism to explicitly label the class/set of classes which make up the event processor as subscribing) is worth keeping the ticket open for. |
I think the idea makes sense, @vab2048, but perhaps we need to look for another annotation or a different configuration approach. |
Sounds good @smcvb. I played around a bit and found a "hacky" workaround which worked for my example app. I put this directly on the component and it worked: Then when I query the app for the running event processors I get it as subscribing: This is probably a hack but I thought I would add it as a result of experimenting. |
Enhancement Description
Allow the
@ProcessingGroup
annotation to also specify the type of the processing group as well as the name.Type being either tracking/subscribing.
Current Behaviour
Processing groups default to tracking event processors unless a config parameter is placed in properties file.
Wanted Behaviour
I would like to make it explicit in the code that I want a subscribing event processor rather than having to look in the config.
Possible Workarounds
This is an enhancement - you could get the desired behaviour by using the config as is done now.
I'm not sure if this would be a desirable feature from your stand point. @smcvb - what do you think?
The text was updated successfully, but these errors were encountered: