Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/move the ResultSet #1422

Open
drvinceknight opened this issue May 11, 2023 · 1 comment
Open

Simplify/move the ResultSet #1422

drvinceknight opened this issue May 11, 2023 · 1 comment
Labels

Comments

@drvinceknight
Copy link
Member

In anticipation of 5.0.0 I wonder if the ResultSet is perhaps worth simplifying a lot. Currently it does a huge amount of calculations (some includes a fair bit of complexity to do all the stuff on disc etc...) that are very specific to the IPD.

I think there are 2 possibilities:

  1. Keep the ResultSet and aim to have it generic so as to do the same amount of calculations for any/all games.
  2. Make the generic output of the Tournament.play() be a payoff matrix and include the option to write the interactions. For the case of the IPD this would lead to no loss of functionality as we would "simply" move the current ResultSet calculations to a specific analysis.ipd spot that we could point at the interactions.

I very much prefer option 2 and wonder if that would streamline things so that we could use the Tournament class in the Moran process? (but this is a minor point)

@marcharper
Copy link
Member

Sounds like a good idea to me. For the generic case we could do something similar to #1353 where the output of a tournament is a fully parseable collection of matches and outcomes -- names of players, match specification including the random seed, etc. Then each game can output some additional computations and plots as desired, with some of those perhaps being generic, such as the score distributions (assuming the Game output is real-valued).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants