WooPayments status and buttons are incorrect on Payments settings page when Stripe onboarding is started but not completed

[timmy5685]

Describe the bug

If a merchant reaches the first screen of stripe onboarding but exits, we display the toggle for WooPayments on the Payments settings screen as enabled and the button as "Manage" which is incorrect. It appears that we are not taking into account whether or not Stripe onboarding steps were completed by the merchant - we just assume after the first stripe onboarding screen is reached that the merchant has completed it.

To Reproduce

1. Install WooPayments
2. Complete MOX and go to first step of Stripe onboarding.
3. Click "Back to WooPayments"
4. Go to WooCommerce > Settings > Payments
5. WooPayments status and button are incorrect in Payment Methods table.

Actual behavior

WooPayments shows as enabled on payment settings screen and button says "Manage" even though the merchant did not complete the onboarding flow.

Screenshots

Expected behavior

WooPayments shows as disabled on payment settings screen and the button says "Finish set up" until the merchant completes the stripe onboarding flow.

[aheckler]

My two cents:

I agree that this is suboptimal and should not happen, but I'm not sure if this issue is specific to WooPayments. For example, if I have a brand new Woo store and I click the toggle to enable the Direct Bank Transfer payment method, it gets enabled (and the button changes to say "Manage" after a page refresh) even though I haven't added my bank account info to it yet.

Same with the Stripe extension: if I install it and go a step or two into the onboarding flow, then return to my site, I see that it's enabled even though I never finished onboarding and cannot take payments or anything with it.

It may be that the larger issue here is that core should somehow be detecting when payment methods are ready to actually take payment vs. just being enabled. That seems like a larger discussion though.