Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooPayments payment method logos component #8808

Open
timmy5685 opened this issue May 9, 2024 · 4 comments
Open

WooPayments payment method logos component #8808

timmy5685 opened this issue May 9, 2024 · 4 comments
Labels
component: onboarding Onboarding merchant in KYC, dev vs live, etc focus: account lifecycle priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.

Comments

@timmy5685
Copy link

timmy5685 commented May 9, 2024

Description

Create shared components for the WooPayments payment method logos so they can be reused and are consistent across all places.

@elizaan36 has created 3 versions of the component: VLWDmeuIXQ7XAK4flyqTFO-fi-2196_11373

The "Expanded" component should be implemented in the following locations:

  • Connect Page V1 - Located in Core (payments nav item)
    image

  • Connect Page V2 - Located in Core (Get paid task page)
    image

  • Connect Page V3 - Located in client
    image

  • Payments Settings Page Marketing Tile (requires WooPayments to be installed, but disabled)
    image

The "Abbreviated 1" component should be implemented in the following location:

  • Payments Settings Page (WooPayments not installed)
    image

Acceptance criteria

  • 3 variations of the shared component are created
  • Pages specified above use their respective components

Designs

WooPayments payment method logos shared component variations: VLWDmeuIXQ7XAK4flyqTFO-fi-2196_11373

@timmy5685
Copy link
Author

@elizaan36 - do you think we should wait to create the "Abbreviated 2" version until we have a place that it's needed?

@dmallory42 - will creating / not creating this version have a serious impact on the effort?

@dmallory42
Copy link
Contributor

@dmallory42 - will creating / not creating this version have a serious impact on the effort?

Good question! I would say it may have a small impact on the effort, but I also think it probably saves time in the long run to think about all the possible variations of the component that we may need in future at this point. 🙂

also cc. @anu-rock as this issue probably needs to be on our radar soon!

@elizaan36
Copy link

elizaan36 commented May 10, 2024

Thanks for creating the issue, @timmy5685

do you think we should wait to create the "Abbreviated 2" version until we have a place that it's needed?

To clarify, it's one component with three variants. The thinking is that the appropriate variant is presented depending on the device size. So Expanded and Abbreviated 2 could appear in the same placement on Payments Connect depending on the viewport. Here's a mockup of Abbreviated 2 for Payments Connect on mobile.
Payments Connect - WP Installed, WPCOM connection required mobile
I think abbreviated 2 would also need to be used for the Payments settings example, when WooPayments isn't installed.

I'm in the process of putting up a P2 with all of the details.

@anu-rock anu-rock added type: enhancement The issue is a request for an enhancement. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. component: onboarding Onboarding merchant in KYC, dev vs live, etc labels May 23, 2024
@anu-rock
Copy link
Contributor

Update: The P2 that @elizaan36 mentioned above was published at paJDYF-dA0-p2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: onboarding Onboarding merchant in KYC, dev vs live, etc focus: account lifecycle priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants