Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions: Add space before Giropay and P24 logo and source_identifier #8804

Closed
mdmoore opened this issue May 9, 2024 · 1 comment · Fixed by #8876
Closed

Transactions: Add space before Giropay and P24 logo and source_identifier #8804

mdmoore opened this issue May 9, 2024 · 1 comment · Fixed by #8876
Assignees
@mdmoore
Labels
focus: reporting good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@mdmoore
Copy link
Member

mdmoore commented May 9, 2024

Describe the bug

On the transactions page, the logo and source_identifier are crowded. I think it just needs a   or 2 here and here.

To Reproduce

  1. Place an order using Giropay as the payment method
  2. View the transaction at Payments > Transactions

Actual behavior

Giropay and P24 transactions have no space between the logo and source_identifier

Screenshots

image image
@mdmoore mdmoore added type: bug The issue is a confirmed bug. focus: reporting labels May 9, 2024
@haszari haszari added good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability labels May 20, 2024
@haszari
Copy link
Contributor

haszari commented May 20, 2024

@mdmoore feel free to fix this if you're in there and can easily reproduce!

@mdmoore mdmoore self-assigned this May 23, 2024
@mdmoore mdmoore mentioned this issue May 24, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmoore mdmoore

Labels
focus: reporting good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add spacing between Giropay and P24 icons and source identifier Automattic/woocommerce-payments
2 participants
@mdmoore @haszari