New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WooPayments REST: conditional initialization. #8805
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
@RadoslavGeorgiev: I have yet to test the manual update process, but the UI works and the PR is available for early feedback. |
@RadoslavGeorgiev: this PR is ready for review. I'd also ask you to confirm the results of the manual testing - on my end the taken approach works, but I want to avoid "works on my machine" scenario 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me! I only tested locally, simulating a plugin upload, and it worked right as expected.
Fixes #8797
Related to woocommerce/woocommerce#47266
Changes proposed in this Pull Request
Initialize REST only in a guaranteed REST context to guarantee the runtime state matches the updated state.
This shall prevent crashes due to rest controllers constructor changes during manual plugin updates.
Testing instructions
npm run build:release
and manually update the plugin.\WC_REST_Payments_Orders_Controller::__construct
and add a new mandatory parameternpm run build:release
and manually update the plugin.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge