Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move usePaymentActivityData() to PaymentActivity from PaymentActivityData because used by filters #8733

Closed
Tracked by #8482
shendy-a8c opened this issue Apr 29, 2024 · 0 comments · Fixed by #8751
Closed
Tracked by #8482

Move usePaymentActivityData() to PaymentActivity from PaymentActivityData because used by filters #8733

shendy-a8c opened this issue Apr 29, 2024 · 0 comments · Fixed by #8751
Assignees
@shendy-a8c
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: reporting type: task The issue is an internally driven task (e.g. from another A8c team).
Milestone
Helix WooPayments...

Comments

@shendy-a8c
Copy link
Contributor

shendy-a8c commented Apr 29, 2024 •
edited

usePaymentActivityData() currently is called in PaymentActivityData.
We need to move it up to PaymentActivity because the filters (eg the preset date range dropdown) will need the return value of usePaymentActivityData(), for example the isLoading so when data is being fetched, the preset date range dropdown can be hidden or disabled.
@shendy-a8c shendy-a8c mentioned this issue Apr 29, 2024
Open
@shendy-a8c shendy-a8c added category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: reporting type: task The issue is an internally driven task (e.g. from another A8c team). labels Apr 29, 2024
@shendy-a8c shendy-a8c self-assigned this May 1, 2024
@shendy-a8c shendy-a8c mentioned this issue May 1, 2024
Merged
6 tasks
@Jinksi Jinksi added this to the Helix WooPayments 7.7 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shendy-a8c shendy-a8c

Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: reporting type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Milestone
Helix WooPayments 7.7
2 participants
@Jinksi @shendy-a8c