New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-decimal currency and XPF multi-currency bugs #5150
Non-decimal currency and XPF multi-currency bugs #5150
Comments
Hey @LevinMedia, it feels great to keep getting your feedback, thank you ❤️ |
This issue impacts Multi-Currency, so assigning to Fractal (based on team responsibilities Pc2DNy-3z-p2) @bborman. Assigning as part of Gamma Triage process PcreKM-yM-p2. Tagging as part of re-evaluating older issues in the backlog, please have a look and close if no longer relevant. |
Hey team! Please add your planning poker estimate with Zenhub @cesarcosta99 @lovo-h @rafaelzaleski @reykjalin @ricardo |
It looks like things are a bit different than the time this has been reported.
The values in the currency preview seem correct now and match what's expected.
The currency codes are retrieved from WC core here. And the
I'm not familiar with this currency and the countries that use it, but according to the
I also did some research and Wikipedia (and a few other sites) indicate that the symbol of the CFP franc currency is The Now, moving to the store frontend.
The trailing |
With the new changes applied in the currency the formatting in the preview is going to be I have conflicting perspectives about this approach because, as much as I understand this being easier for the store owner to understand the conversion, it's not representing accurately how the currency is going to be presented. @bborman22, I would appreciate a second opinion here to decide if we should keep this behavior, or change it to display the actual currency formatting. |
Sorry I don't have a super strong understanding of the difference between this preview and the actual display, but I would expect them to match. This conflict between using store currency formatting in the admin has been a consistent problem I'm looking to get addressed. Given the explicit context here that this is a preview of how it will be displayed, I would say we should use the front-end display rules if we can? |
The Pacific Franc (XPF, a non decimal currency) has a number of bugs in both the currency management screen, and on the front end of the store.
Currency management screen:
In the screen shot above, the preview price should be 115 and the currency symbol should be XPF, and precede the price with a space. In the example above, I would expect to see the preview displayed as XPF 115 This preview bug seems to affect ALL non decimal currencies. Here's another screen shot of Yen - although the yen currency symbol is placed correctly.
The preview price should be ¥140
On the store front
On the front end of the store, the prices appear to be calculated correctly, however for the XPF currency, they're missing the coma separator for thousands, and also using the incorrect symbol (Trailing Fr, rather than the correct XPF preceding with a space) I tested for this using Yen, and the coma was placed correctly, so it looks like it might just be limited to XPF
I've attached a few screen shots from business that charge customers in XPF to show how XPF is used as the currency symbol.
The text was updated successfully, but these errors were encountered: