Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align deposit status colour coding across pages #7761

Open
bradyv opened this issue Nov 21, 2023 · 5 comments · May be fixed by #8382
Open

Align deposit status colour coding across pages #7761

bradyv opened this issue Nov 21, 2023 · 5 comments · May be fixed by #8382
Assignees
@shendy-a8c
Labels
component: deposits Issues related to Deposits focus: deposits good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug. type: enhancement The issue is a request for an enhancement.

Comments

@bradyv
Copy link
Contributor

bradyv commented Nov 21, 2023 •
edited by haszari

Description

Presently we apply colour coding to deposit status differently depending on where they're displayed. It would be great to bring consistency to the visual cues and reduce some of the cognitive load of understanding deposits.

Screenshot 2023-11-21 at 11 17 07

Acceptance criteria

Consistent colours are used throughout WooPayments to represent disputes at each stage.

Statuses

  • Pending -> yellow
  • In transit -> blue
  • Paid -> green
  • Failed -> red
  • Canceled -> gray
@bradyv bradyv added the type: enhancement The issue is a request for an enhancement. label Nov 21, 2023
@brucealdridge brucealdridge added the component: deposits Issues related to Deposits label Nov 21, 2023
@haszari haszari added the type: bug The issue is a confirmed bug. label Nov 21, 2023
@haszari haszari added good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability labels Dec 20, 2023
@haszari
Copy link
Contributor

haszari commented Dec 20, 2023

Nice quick-fix. Not urgent but a great thing to tidy up so medium priority.

@naman03malhotra
Copy link
Contributor

@bradyv can you please share the color codes you'd like us use for consistent visual behavior?

@naman03malhotra naman03malhotra self-assigned this Mar 4, 2024
@haszari
Copy link
Contributor

haszari commented Mar 4, 2024

can you please share the color codes you'd like us use for consistent visual behavior?

FYI @naman03malhotra @bradyv isn't working with us any longer (though maybe he'll reply as a civilian!)

I'd recommend using the existing colours – we already have colours in place, but we're just using them inconsistently. If there are gaps, feel free to find colours from elsewhere in the UI and/or colour schemes/libraries.

@rogermattic or @elizaan36 can advise and review, though there's no need to wait on design to start implementing! Possibly no need for design on this if we're using existing colours to make dispute status consistent across all UI/screens.

@naman03malhotra
Copy link
Contributor

I'd recommend using the existing colours – we already have colours in place, but we're just using them inconsistently

@haszari My question largely is, if we have two variations of the same color which one to standardize. My step would be to find inconsistency in colors and ask design which one to pick.

@rogermattic
Copy link

I'd recommend using the existing colours – we already have colours in place, but we're just using them inconsistently. If there are gaps, feel free to find colours from elsewhere in the UI and/or colour schemes/libraries.

@rogermattic or @elizaan36 can advise and review, though there's no need to wait on design to start implementing! Possibly no need for design on this if we're using existing colours to make dispute status consistent across all UI/screens.

1000% agree! Please use the existing colours.

My question largely is, if we have two variations of the same color which one to standardize. My step would be to find inconsistency in colors and ask design which one to pick.
[
Would you be able to check the colours and the style here in this Figma

@naman03malhotra naman03malhotra linked a pull request Mar 14, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shendy-a8c shendy-a8c

Labels
component: deposits Issues related to Deposits focus: deposits good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introducing consistency in colors for deposits across pages Automattic/woocommerce-payments
6 participants
@brucealdridge @bradyv @haszari @naman03malhotra @shendy-a8c @rogermattic