Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show schedule summary in-context within the deposits list table (requires refactor) #8260

Open
haszari opened this issue Feb 22, 2024 · 1 comment · May be fixed by #8239
Open

Show schedule summary in-context within the deposits list table (requires refactor) #8260

haszari opened this issue Feb 22, 2024 · 1 comment · May be fixed by #8239
Labels
component: deposits Issues related to Deposits focus: deposits priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.

Comments

@haszari
Copy link
Contributor

haszari commented Feb 22, 2024 •
edited

Describe the bug

Spun off from:

There are two requirements in that issue:

  1. Ensure the notice uses same wording, etc as the deposit schedule info in Payments Overview.
  2. Adjust the placement and styling of the notice so it's inside the table box, closer to context.

Originally we planned to fix both at once, though after my investigation I think we'll need to refactor and may need updated @woocommerce/components to insert content within the table.

This issue is for that refactor.

Spun off this issue to unblock fix (1) - consistent wording, not showing an estimated date.

Designs

We should keep the logic of how this notice behaves and change the design so it's rendered inline in that table.

Important

We should use consistent wording with the Payments → Overview deposit schedule message, without the estimated date. See #8184 for details.

Deposits

Additional context

See slack discussion: p1705271101815789-slack-C045PC0V40G
@haszari haszari added type: bug The issue is a confirmed bug. component: deposits Issues related to Deposits labels Feb 22, 2024
@haszari haszari mentioned this issue Feb 22, 2024
Closed
haszari pushed a commit that referenced this issue Feb 23, 2024
tweak dismiss so note text is vertically centred:
77d7002 
- short term fix
- this hack & component will be replaced soon (InlineNotice, #8260)
This was referenced Feb 23, 2024
Draft
Closed
haszari pushed a commit that referenced this issue Feb 23, 2024
tweak dismiss so note text is vertically centred:
93b8f93 
- short term fix
- this hack & component will be replaced soon (InlineNotice, #8260)
@haszari haszari added type: enhancement The issue is a request for an enhancement. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. and removed type: bug The issue is a confirmed bug. labels May 15, 2024
@haszari
Copy link
Contributor Author

haszari commented May 15, 2024

Switching to low enhancement as we'd need significant effort / upstream changes to implement the proposed design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: deposits Issues related to Deposits focus: deposits priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
2 participants
@vbelolapotkov @haszari