Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe 2: No way to remove italics from image captions #7701

Open
cuemarie opened this issue Mar 25, 2024 · 4 comments
Open

Apostrophe 2: No way to remove italics from image captions #7701

cuemarie opened this issue Mar 25, 2024 · 4 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] TBD Triaged [Type] Bug Something isn't working

Comments

@cuemarie
Copy link

cuemarie commented Mar 25, 2024

Quick summary

Image captions are all italicized by default in theme Apostrophe 2; Gutenberg offers block tools to add bold or italics to captions, but this has no impact on the italicization of captions since it's there by default. This means customers can only remove that italicization with CSS.

Steps to reproduce

  1. Activate Apostrophe 2 on a WordPress.com site
  2. On a page, add an image with a caption. (Observe the caption is italicized).
  3. Try making the caption not italicized.

What you expected to happen

For there to be any control over the italicized captions, especially given the block tools.

What actually happened

The block tools cannot remove italicization from the image captions.

CleanShot 2024-03-25 at 12 05 11@2x

Browser

No response

Context

No response

Platform (Simple, Atomic, or both?)

Simple, Atomic

Other notes

CleanShot 2024-03-25 at 12 04 00@2x

Inspecting the image captions shows the following CSS being applied:

[class^="wp-block-"] figcaption {
  font-style: italic;

Customer report was on an AT site; I replicated on my own Simple Site

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Workaround details

/* remove italicized captions with no-italics class | xxx-zen */
.no-italics .wp-element-caption {
    font-style: normal !important;
}

Then adding no-italics as an additional class to images, galleries, or groups containing either.

@cuemarie cuemarie added [Type] Bug Something isn't working Needs triage [Feature Group] Appearance & Themes Features related to the appearance of sites. labels Mar 25, 2024
@cuemarie
Copy link
Author

Customer Report: 7941491-zen

This customer did not want to use CSS to workaround, so they're rebuilding their content instead. They would like a follow up if we resolve this. (feel free to ping me here or in slack if you close/fix, and I can follow up with them). Thanks!

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • -zen
  • 7941491-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Mar 25, 2024
@maciejpilarski
Copy link

📌 REPRODUCTION RESULTS
– Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
I was able to reproduce the issue.

📌 ACTIONS
– triaged

@Aurorum
Copy link
Contributor

Aurorum commented Mar 27, 2024

I'm not really sure how to go about this. Ideally, any changes wouldn't apply retrospectively and force users to re-italicise their captions. That could mean adding a setting in the Customizer to give users control of this, but that feels a little overkill for one request?

V curious for thoughts on different approaches here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] TBD Triaged [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

3 participants