Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quiz is always marked as passed when the lesson is completed #7379

Open
m1r0 opened this issue Dec 12, 2023 · 2 comments · May be fixed by #7381
Open

Quiz is always marked as passed when the lesson is completed #7379

m1r0 opened this issue Dec 12, 2023 · 2 comments · May be fixed by #7381
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug

Comments

@m1r0
Copy link
Member

m1r0 commented Dec 12, 2023 •
edited

Steps to Reproduce

  1. Create a course containing a lesson with a quiz.
  2. Don't submit the quiz or submit the quiz for grading.
  3. Complete the lesson.
  4. Go back to the quiz, it says that you've completed the quiz and there is a message saying "You've passed the quiz".
  5. If you've submitted the quiz for grading, it will allow you to re-submit the quiz even if the "Retake" option is off.

What I Expected

If the quiz is not submitted, it shouldn't say that the quiz is completed and passed.
If the quiz is submitted for grading, the UI should be the same as before and the user should see "Your answers have been submitted and the quiz will be graded soon".
If the quiz is submitted for grading and the "Retake" option is off, the user shouldn't be able to retake the quiz.

What Happened Instead

The user sees a "Quiz completed" and "You've passed the quiz" and can retake the quiz.

PHP / WordPress / Sensei LMS version

PHP: 7.4
WordPress: 6.4.2
Sensei LMS: 4.19.2

Video

Not submitting the quiz:

D2J2X9.mp4

Quiz submitted for grading:

HZlyIR.mp4

Context / Source

7375078-zen
@m1r0 m1r0 added [Type] Bug [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged labels Dec 12, 2023
@m1r0 m1r0 mentioned this issue Dec 12, 2023
Closed
@github-actions GitHub Actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 7375078-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Dec 12, 2023
@m1r0 m1r0 linked a pull request Dec 12, 2023 that will close this issue
Draft
14 tasks
@m1r0
Copy link
Member Author

m1r0 commented Dec 12, 2023

@donnapep Let me know if I should invest more time in this. I did a quick POC fix in the linked PR, but there is still work to be done like testing more in debt, fixing tests, and fixing the grading screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix quiz marked as passed when lesson is complete Automattic/sensei
1 participant
@m1r0