Fix 1686 grid margins go off screen #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroalonso
force-pushed
the
release/7.63
branch
2 times, most recently
from
e2685b7
to
4c7c755
Compare
leandroalonso
requested changes
May 10, 2024
leandroalonso
requested changes
May 10, 2024
There was a problem hiding this comment.
@SergioEstevao I don't believe trunk has the grid changes applied. We probably need to re-add them, merge them first, and then update this PR.
Edit: or maybe we could use this one? Anyways, there's some merge conflict.
|
I will pull the other one before, because this fix only makes sense when you have horizontal margins to test. |
|
@leandroalonso ready for another look now that we re-added the new grid layout to trunk. |
SergioEstevao
commented
May 14, 2024
podcasts/SceneHelper.swift
Outdated
| @@ -26,7 +26,8 @@ class SceneHelper { | |||
| class func rootViewController() -> UIViewController? { | |||
| guard !FeatureFlag.newPlayerTransition.enabled else { | |||
| let appScene = connectedScene()?.windows.first(where: { $0.rootViewController is MainTabBarController }) | |||
| return appScene?.rootViewController?.topMostPresentedViewController | |||
| let rootVC = appScene?.rootViewController | |||
There was a problem hiding this comment.
These changes were not part of this PR, This comes from another PR that is still not merged in trunk.
There was a problem hiding this comment.
Just a merge trunk missing. :)
Gone already.
leandroalonso
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1686
This PR updates the search bar code and mini-player code to ensure it does not change any existing horizontal insets when updating the insets.
To test
Close and Clear Up NextChecklist
CHANGELOG.mdif necessary.