Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover: Subscribe button is not getting updated in category view #1682

Open
1 task done
mebarbosa opened this issue May 1, 2024 · 4 comments
Open
1 task done
Assignees
Labels
Bug Something isn't working Discover UI Related UI related issues (colors, icons, etc)

Comments

@mebarbosa
Copy link

Description

The subscribe button does not turn green after subscribing to a podcast, and it doesn't change back when we unsubscribe from a podcast

Step-by-step reproduction instructions

  1. Go to Discover tab
  2. Select a category
  3. Subscribe to a podcast from the podcast filtered list
  4. ❌ See the subscribe button does not update to green
  5. Open this podcast you subscribed and unsubscribe it
  6. Go back to discover
  7. ❌ See the subscribe button does not reflect that you unsubscribed the podcast

Screenshots or screen recording

RPReplay_Final1714575771.MP4

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Pocket Casts 7.62.0.3

@mebarbosa mebarbosa added UI Related UI related issues (colors, icons, etc) Discover labels May 1, 2024
@bjtitus bjtitus self-assigned this May 1, 2024
@bjtitus
Copy link
Contributor

bjtitus commented May 1, 2024

Are we sure the color is supposed to be green when subscribing from the categories screen?. I'm guessing the long list could be updated to green but would like to check with @david-gonzalez-a8c.

The current behavior matches the other long list pages.

See the "Show All" page from the "Popular" Discover cell:

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-01.at.10.01.29.mp4

And also the old Category page (which uses the same code as the current implementation):

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-01.at.10.06.30.mp4

@bjtitus
Copy link
Contributor

bjtitus commented May 1, 2024

The unsubscribe bug is carried over from the old Category page, so nothing new with the FF. Looking for a fix now.

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-01.at.10.08.19.mp4

@bjtitus bjtitus added the Bug Something isn't working label May 1, 2024
@mebarbosa
Copy link
Author

Thanks for taking a loot at this @bjtitus Let's wait for @david-gonzalez-a8c maybe there is a small parity diff with Android. In Android the subscription button always updates to green

@david-gonzalez-a8c
Copy link

It's hard to tell, but my guess is that the icon not turning green in some places is not intentional. Let's make it green in all places and both platforms if that's not too complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Discover UI Related UI related issues (colors, icons, etc)
Projects
None yet
Development

No branches or pull requests

3 participants