Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related to the isPaid feature #1649

Open
SergioEstevao opened this issue Apr 24, 2024 · 2 comments
Open

Remove code related to the isPaid feature #1649

SergioEstevao opened this issue Apr 24, 2024 · 2 comments
Labels
Milestone

Comments

@SergioEstevao
Copy link
Contributor

When updating the grid cell design for podcasts I found code related to never implemented featured: paid podcasts.

We should remove all code related to this:

  • Remove isPaid from podcasts
  • Remove supporterHeart property from podcasts cells
  • Delete PodcastHeartViewclass
@SergioEstevao SergioEstevao added this to the Future milestone Apr 24, 2024
@SanjaySiddharth
Copy link

Hey Sergio ! I would love to work on this request !

@SanjaySiddharth
Copy link

I feel like this function would be of no use if paid podcasts are to be removed . Please have a look at it and let me know if I can remove them from podcasts PodcastDataManager file:

    func allPaidPodcasts(dbQueue: FMDatabaseQueue) -> [Podcast] {
        var allPaid = [Podcast]()
        cachedPodcastsQueue.sync {
            for podcast in cachedPodcasts.values {
                if !podcast.isPaid { continue }

                allPaid.append(podcast)
            }
        }

        return allPaid
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants