Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine pills animation in Discover #1647

Open
1 task done
david-gonzalez-a8c opened this issue Apr 24, 2024 · 2 comments
Open
1 task done

Refine pills animation in Discover #1647

david-gonzalez-a8c opened this issue Apr 24, 2024 · 2 comments
Labels
Discover UI Related UI related issues (colors, icons, etc)

Comments

@david-gonzalez-a8c
Copy link

Description

The animation when selecting the pills looks a bit clunky, specially when selecting the pills displayed last. Because the pill "travels" a lot of distance, including the scrollable distance to the beginning of the pills container, the animation ends up looking a bit abrupt. With some pills there's also a strange "bounce" effect ("Society and Culture"), can't point out why. Can we please try and smooth it out?

I suggest we either make the pill travel a shorter distance, without the scrollable distance, or adjust the speed of the animation depending on it (longer distance = longer animation).

I'm attaching a good reference in the app Cosmos (let me know if you'd like an invitation).

Step-by-step reproduction instructions

  1. Go to "Discover"
  2. Play with selecting and unselecting the pills on top, specially the last ones

Screenshots or screen recording

093BA714-0460-4346-89D3-F8F8BFC9E0D6.MP4
A426C1E0-3E81-448E-8FDC-BF6AB8D327BD.MP4

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

No response

@david-gonzalez-a8c david-gonzalez-a8c added UI Related UI related issues (colors, icons, etc) Discover labels Apr 24, 2024
@bjtitus
Copy link
Contributor

bjtitus commented May 14, 2024

@david-gonzalez-a8c What do you think of this change to the animation?

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-14.at.15.53.19.mp4

Here it is slowed down:

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-14.at.15.52.58.mp4

If it looks good, I can submit the code changes!

@david-gonzalez-a8c
Copy link
Author

Looks great!

Let's release it, it's a big improvement. I'll check on my devices and suggest further tweaks if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discover UI Related UI related issues (colors, icons, etc)
Projects
None yet
Development

No branches or pull requests

2 participants