Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deselect Chapters: crash when scrolling #1565

Open
leandroalonso opened this issue Mar 25, 2024 · 1 comment
Open

Deselect Chapters: crash when scrolling #1565

leandroalonso opened this issue Mar 25, 2024 · 1 comment
Labels
crash Crash related issues Deselecting Chapters

Comments

@leandroalonso
Copy link
Member

From Sentry:

Attempted to scroll the table view to an out-of-bounds row (13) when there are only 10 rows in section 0. Table view: <UITableView: 0x1431c0600; frame = (0 0; 393 735); clipsToBounds = YES; autoresize = RM+BM; gestureRecognizers = <NSArray: 0x301863ed0>; backgroundColor = UIExtendedSRGBColorSpace 0 0 0 1; layer = <CALayer: 0x301788e20>; contentOffset: {0, 0}; contentSize: {393, 544}; adjustedContentInset: {0, 0, 34, 0}; dataSource: <podcasts.ChaptersViewController: 0x145322e10>>
@leandroalonso
Copy link
Member Author

Probably happens because scrollToCurrentlyPlayingChapter relies on the chapter index, so if the user deselects any chapters these indexes are not accurate anymore.

@leandroalonso leandroalonso mentioned this issue Mar 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash Crash related issues Deselecting Chapters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leandroalonso