Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for lqr_speed_steer_control.py #705

Open
mrunaljsarvaiya opened this issue Aug 3, 2022 · 7 comments
Open

Documentation for lqr_speed_steer_control.py #705

mrunaljsarvaiya opened this issue Aug 3, 2022 · 7 comments

Comments

@mrunaljsarvaiya
Copy link

mrunaljsarvaiya commented Aug 3, 2022

Is there any documentation on what the variables being passed around in lqr_steer_control.py mean and a reference to the formulas used?

I'm a little confused as to how the desired path point is selected using calc_nearest_index. Why does the index get incremented if you're selecting the current goal to be the path point closest to you? In theory wouldn't you simply hone in on the first index you're trying to reach and never move away from it since lqr would move you towards that index? Or cause you're also selecting a goal velocity do you naturally overshoot that position and start moving towards the next one?

@Zireael07
Copy link

Why close? I can't see any commits that would've improved the docs...

@AtsushiSakai
Copy link
Owner

I agree we can improve the doc, so reopen this.

@AtsushiSakai AtsushiSakai reopened this Aug 4, 2022
@mrunaljsarvaiya
Copy link
Author

mrunaljsarvaiya commented Aug 4, 2022

I closed it cause I was able to figure out what I didn't understand, but yeah it could use more formal documentation

@AtsushiSakai
Copy link
Owner

Your PR is welcome to add your findings!!

@Kim8178184977
Copy link

Can I work on the doc? , because I am a beginner and not too good at the code work

@AtsushiSakai
Copy link
Owner

Yes!! Anyone’s PR is welcome!!

@Kim8178184977
Copy link

thanks, sir can I see the details and the code directory

Repository owner deleted a comment from Kim8178184977 Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants