Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check dipy compatibility #77

Open
matteofrigo opened this issue Sep 27, 2019 · 2 comments
Open

check dipy compatibility #77

matteofrigo opened this issue Sep 27, 2019 · 2 comments

Comments

@matteofrigo
Copy link
Contributor

With the recent update of dipy, many functions will not work.
There are two possible solutions:

  • Require an old version of dipy (suboptimal)
  • Do a complete revision of the parts of dmipy where dipy is used (will take longer than expected)

What do we do @rutgerfick ?

@rutgerfick
Copy link
Collaborator

Where are the spots you think it's broken? only median_otsu?

The python3 tests pass with dipy 1.0, so it must be something that's not in the tests.

@matteofrigo
Copy link
Contributor Author

matteofrigo commented Oct 2, 2019

For sure median_otsu, but I think it will be better to go through the whole list of changed functions and just check if they are used anywhere. Although it's mostly streamlines-related functions, which makes the job much easier as they are never used in dmipy.

For the records, one case in which median_otsu is used is discussed in #76 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants