Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update method visibility and remove deprecated #13

Open
6 tasks done
Gummibeer opened this issue Jun 20, 2019 · 1 comment
Open
6 tasks done

update method visibility and remove deprecated #13

Gummibeer opened this issue Jun 20, 2019 · 1 comment
Assignees
@Gummibeer
Labels
next major release

Comments

@Gummibeer
Copy link
Member

Gummibeer commented Jun 20, 2019 •
edited

Please comment if you have a reason why the method should stay public and be added to the public API.

visibility:

  • \Astrotomic\Translatable\Translatable::getLocaleKey
  • \Astrotomic\Translatable\Traits\Relationship::getTranslationModelName
  • \Astrotomic\Translatable\Traits\Relationship::getTranslationModelNameDefault
  • \Astrotomic\Translatable\Traits\Relationship::getTranslationModelNamespace
  • \Astrotomic\Translatable\Traits\Relationship::getTranslationRelationKey

deprecated:

  • \Astrotomic\Translatable\Traits\Relationship::getRelationKey
@Gummibeer Gummibeer self-assigned this Jun 20, 2019
@Gummibeer Gummibeer mentioned this issue Feb 13, 2020
Closed
@Levivb
Copy link

Levivb commented Oct 24, 2021

checked our codebase of about 1 million lines of code (including whitespace). Only a single time getTranslationModelName got leaked out and that specific integration is internally being deprecated.

So as far as I'm concerned: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gummibeer Gummibeer

Labels
next major release
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Levivb @Gummibeer