Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Error on Composer Update #797

Open
abdulrahman156 opened this issue Nov 25, 2020 · 3 comments
Open

Getting Error on Composer Update #797

abdulrahman156 opened this issue Nov 25, 2020 · 3 comments

Comments

@abdulrahman156
Copy link

Summary of issue

Getting Error on composer update
Problem 1
- idavoll/core-module dev-master requires nwidart/laravel-modules ^8.0 -> found nwidart/laravel-modules[dev-master, 8.0.0, 8.0.x-dev (alias of dev-master), 8.1.0, 8.2.0] but it conflicts with your root composer.json require (^4.0).
- idavoll/core-module 4.0.x-dev is an alias of idavoll/core-module dev-master and thus requires it to be installed too.
- Root composer.json requires idavoll/core-module 4.0.x-dev -> satisfiable by idavoll/core-module[4.0.x-dev (alias of dev-master)].

Steps to reproduce

composer update on existing project

System Details

Here is my composer json file

"name": "asgardcms/platform",
"description": "The AsgardCms application.",
"keywords": [
"cms",
"asgardcms",
"multilingual",
"laravel",
"laravel5"
],
"license": "MIT",
"type": "project",
"require": {
"php": "^7.1.3",
"braintree/braintree_php": "4.7.0",
"cartalyst/sentinel": "^2.0",
"fideloper/proxy": "^4.0",
"idavoll/adminlte-theme": "4.0.x-dev",
"idavoll/core-module": "4.0.x-dev",
"idavoll/dashboard-module": "4.0.x-dev",
"idavoll/flatly-theme": "4.0.x-dev",
"idavoll/media-module": "4.0.x-dev",
"idavoll/menu-module": "4.0.x-dev",
"idavoll/page-module": "4.0.x-dev",
"idavoll/setting-module": "4.0.x-dev",
"idavoll/tag-module": "4.0.x-dev",
"idavoll/translation-module": "4.0.x-dev",
"idavoll/user-module": "4.0.x-dev",
"idavoll/workshop-module": "4.0.x-dev",
"laravel-validation-rules/credit-card": "^1.1",
"laravel/framework": "5.7.",
"laravel/tinker": "^1.0",
"nwidart/laravel-modules": "^4.0",
"sendgrid/sendgrid": "^7.3",
"stechstudio/laravel-ssh-tunnel": "^2.1",
"tymon/jwt-auth": "1.0.
"
},
I am using php v7.3.*

@mikemand
Copy link
Contributor

Asgard v4 is now at Laravel 8. The only breaking changes, as far as I could tell when upgrading my modules, was that you either have to install the new laravel/helpers package or change all of the str_* and arr_* helpers to their \Illuminate\Support\Str::* and \Illuminate\Support\Arr::* counterparts. If you have any deferrable service providers ($defer = true;), you need to change them to the new trait-based deferrable way of doing things.

I would create a new Asgard project (either download master as a zip, clone master to a different directory, or use composer/Asgard installer), then use a file comparison tool to see what all you need to change in the root (things like composer.json, package.json, etc.) and app directories.

@abdulrahman156
Copy link
Author

so what about for previous projects? I have many projects in laravel 5.7. I dont want to update anything. Could you please tell me what version should i use for 5.7?
Upgrading should be on new version# rather than existing one.

@mikemand
Copy link
Contributor

mikemand commented Nov 27, 2020

Hi @abdulrahman156,

I'm sorry about the slow reply, yesterday was a national holiday for me. If you don't want to upgrade to Laravel 8, you'll need to use a specific commit hash to keep using Laravel 5.7. For example, for the Core module, you'd need to use this hash: c55235fd8a14390a981b10c5ff26a5f73d5e4180. That was the last one to be on Laravel 5.7. You'll have to check the other Asgard modules you use to see which hashes to use: https://github.com/Idavoll. You'll want anything before November 1st, as that was when the first PR upgrading to Laravel 5.8 was merged.

Yes, I agree upgrading should be on a new version number, however, Asgard v4 was never officially released. I don't know if Nicolas would tag the commit just before the upgrade to Laravel 5.7 as v4, then tag the other major Laravel jumps as a new major, or if he'll even tag a v4 at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants