Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action doesn't fail if Asana task isn't in a project where the GitHub Action is allowed to run in #32

Open
psypuff opened this issue Aug 2, 2023 · 1 comment

Comments

@psypuff
Copy link

psypuff commented Aug 2, 2023

We were under the impression the action should fail if the attachment fails for any reason. This is a blocker for us since we need to prevent PR merges if it's not attached to an Asana task.
In some cases we get the following response but it returns with a 200 status so the action passes and let the PR merge although it wasn't really attached to an Asana task:

[
  {
    task: '...',
    result: 'GitHub Widget attachment/comment failed because the task is not in a project where the GitHub Action is allowed to run in. Please add any of the project IDs [...] to allowed projects list in the GitHub Action configuration file or add the task to an allowed project.'
  }
]

This could be controlled by some strict variable if there's a need to support current behavior.
Another option could be exposing the response as an output for further steps to fail the whole workflow like suggested here.

@psypuff
Copy link
Author

psypuff commented Aug 2, 2023

Another similar issue this could alleviate - the action doesn't fail even if there's no Asana link in the PR description which kinda beats the whole purpose of that action (assuming one would like to enforce its existence).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant