Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected behaviour plots.series_per_group #215

Open
HMEUW opened this issue May 3, 2024 · 0 comments
Open

unexpected behaviour plots.series_per_group #215

HMEUW opened this issue May 3, 2024 · 0 comments

Comments

@HMEUW
Copy link
Collaborator

HMEUW commented May 3, 2024

The plots.series_per_group function gives an unexpected behaviour.

https://github.com/ArtesiaWater/hydropandas/blob/2426022ead74875a5f5abf6830c405d07533e78c/hydropandas/extensions/plots.py#L740C20-L740C52

When only one column provided as by
When groupname is a string, than the filename is spoiled with - symbols, e.g. series_by_monitoring_well_group_P-B-4.png
When groupname is a float or int, the function fails.

My solution is to exclude this line.

When a list is provided as by
You expect something as the join function. Therefore 2 lines up, include: groupname = '-'.join(str(x) for x in groupname)

Maybe I missed something in the function logic. Otherwise, I will fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant