Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make service sharing more explicit in policy language #305

Open
romangithub1024 opened this issue Apr 27, 2018 · 0 comments
Open

Make service sharing more explicit in policy language #305

romangithub1024 opened this issue Apr 27, 2018 · 0 comments
Assignees
@romangithub1024
Labels
type/task Task
Milestone
Version 0.2 - Tasks

Comments

@romangithub1024
Copy link
Contributor

romangithub1024 commented Apr 27, 2018 •
edited

Make it more verbose ("allocation keys" is not verbose enough)

  • type = singleton (make it obvious that there is always one instance)
  • type = shared + specify scope (make it obvious that same key gets the same instance)
  • type = dedicated (make it obvious that every dependency gets its own instance)
    • right now "{{ .Dependency.ID }}" doesn't look too good in the policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romangithub1024 romangithub1024

Labels
type/task Task
Projects
None yet
Milestone
Version 0.2 - Tasks
Development

No branches or pull requests
1 participant
@romangithub1024