Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeled inputs ability to set label position #416

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

esraay
Copy link
Contributor

@esraay esraay commented Jul 8, 2022

Closes #235

This PR provides to add fomanticUI label classes to inputs. This way, the input's label position/type/color can be set.
Basic examples for its use are included in the example file.
Official documentation is referenced.

DoD

  • Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.

  • Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.

  • No new error or warning messages are introduced.

  • All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.

  • If the change affects code or repo sctructure, README, documentation and code comments should be updated.

  • All code has been peer-reviewed before merging into any main branch.

  • All changes have been merged into the main branch we use for development (develop).

  • Continuous integration checks (linter, unit tests) are configured and passed.

  • Unit tests added for all new or changed logic.

  • All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.

  • Any added or touched code follows our style-guide.

@esraay esraay requested a review from jakubsob July 8, 2022 10:19
@esraay esraay changed the title Esra labeled inputs ability to set label position Labeled inputs ability to set label position Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeled inputs - ability to set label's position (left or right)
2 participants