Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial and examples #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DouglasMesquita
Copy link
Collaborator

@DouglasMesquita DouglasMesquita commented Mar 12, 2023

Link to the Issue

close #104

Definition of Done

For each one of the examples/tutorials:

  • Use app <- AppDriver$new only once
  • Call app$close at the end of the code
  • Force the installation of the newer shiny version using renv::install

How to test changes

Follow tutorial instructions and be sure it works if you follow correctly the steps

Tasks for PR author

  • Test your change and ensure there is no regression
  • Change has a corresponding issue. Ensure it is linked in GitHub
  • Author of the change opened a pull request and assigned a reviewer

General policy:

  • If applicable - add instructions for testing
  • If there’s no issue, create it. Each issue needs to be well defined and described.
  • All interaction with a user, user-facing messages, plots, reports etc. are written from the perspective of the person using or receiving it. They are understandable and helpful to this person. If a user sees an error message, there is a call to action, i.e. the user knows what to do to fix it.
  • README, other documentation and code comments that we have is updated with all information related to the change.
  • All code has been peer-reviewed before merging into any main branch
  • All changes have been merged into the main branch we use for development.
  • Continuous integration checks (linter, unit tests, integration tests) are configured and pass.
  • Optional: unit tests added for all new or changed logic.
  • All task requirements satisfied. If not describe it here. The reviewer is responsible to verify each aspect of the task.
  • Change covers only things in task. Please create new PR if you want to fix something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial has some problems after package updates
1 participant