New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bid and Ask might require specific rounding #6

Open

benoitx opened this issue Oct 13, 2014 · 1 comment

Assignees

Labels

Contributor

benoitx commented Oct 13, 2014

rounding - I see you always use ROUND_HALF_UP, when for the bid this might not be desirable - you could make rounding user definable

benoitx added the enhancement label

benoitx self-assigned this

benoitx added a commit that referenced this issue


          Issue #6 first cut for bid/ask rounding

c031c84

benoitx added a commit that referenced this issue


          issue #6 use HALF_DOWN for default for bid

5c5212e

ancgate commented Jul 22, 2021

Some currencies don't accept decimals. We might take that into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment