Plans to rework internals around the notification system

[wax911]

I'm creating this discussion to add onto #419 (comment)

As it stands the current implementation around notifications allows the user to read notifications on anilist and mark them as read on the site and have the application still show an unread indicator on them. The same could be done for AT to some extent to prevent constant notification reminders if the notification contents have not changed, e.g. instead of storing all the read notification ids we could just store the last read Id and last received Id but allow the user decide what happens when they swipe the notification away. I believe this would achieve what you want @youssefhabri right?

I'm going to tag @taichikuji @luk1337 to see if they have any other ideas

[luk1337]

instead of storing all the read notification ids we could just store the last read Id and last received Id

Well...currently, we are always sending notifications for min(unread, 5) notifications even if one of them in that set is marked as read on anilist so we could just store these 5 ids.

[luk1337]

Or better, if we continue with min(unread, 5) we could just store top id and nothing else.

[wax911]

Or better, if we continue with min(unread, 5) we could just store top id and nothing else.

That's what I was thinking too

[luk1337]

I think that'd be fine and relatively low effort.

[luk1337]

Then we'd also have to rename dismiss option to "mark as read on dismiss" ^^

[luk1337]

@wax911 have you ever noticed that clear notifications work just doesn't seem to run after some time? Maybe there are some background execution restrictions in newer Android versions...
I placed breakpoints everywhere and it appears that the job reaches the scheduling part just fine but never hits doWork() in ClearNotificationWorker.

[luk1337]

I've had an idea that maybe replacing ExistingWorkPolicy.KEEP with ExistingWorkPolicy.REPLACE will help in some way or at least if we do that then it'll just clear notifications immediately in case previously scheduled work failed and is awaiting the backoff period.

[wax911]

I bad never tested this enough times to notice, If it works around the issue then we can give it shot. Sorry for the late reply I'm not at home and only going to be back tomorrow