Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

row-property is a noop? #360

Open
bigmistqke opened this issue Jan 9, 2023 · 2 comments
Open

row-property is a noop? #360

bigmistqke opened this issue Jan 9, 2023 · 2 comments

Comments

@bigmistqke
Copy link

I just noticed in the example-site that the row-attribute is not doing anything:
Screenshot 2023-01-09 at 18 19 45
these are not 4 rows.

is this expected behavior?
I understand that 'row' is a bit of an odd property in the first place when using an auto-growing textarea, but if it is a noop, then it would be better to just give a type-error imo.

btw I am making a port of react-textarea-autosize for solid

@bigmistqke
Copy link
Author

either noop and type-error, or allow it and row={4} === minRow={4} maxRow={4} imo

@Andarist
Copy link
Owner

Andarist commented Jan 9, 2023

I'd probably remove this from the types (and from examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants