Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept::suggested values not populated for ConceptOptional structs #1233

Open
kevzettler opened this issue Dec 19, 2023 · 0 comments
Open

Comments

@kevzettler
Copy link
Contributor

Using the Transformable concept as an example:

Transformable {
   ..Transformable::suggested()
}.make()

I would expect that this makes a Transformable with the suggested values. It does not and the translation value is None furthermore:

Transformable {
    optional: TransformableOptional::default(),
    ..Transformable::suggested()
}

I would expect that this example would populate the optional fields with TransformableOptional::default values it does not. they all come in as None

You can log these values and see that they are None

println!("Transformable {:?}", Transformable::suggested());
println!(
   "TransformableOptional default? {:?}",
    TransformableOptional::default()
 );
15:34:03  INFO ambient::server::wasm: stdout: Transformable Transformable { local_to_world: Mat4 { x_axis: Vec4(1.0, 0.0, 0.0, 0.0), y_axis: Vec4(0.0, 1.0, 0.0, 0.0), z_axis: Vec4(0.0, 0.0, 1.0, 0.0), w_axis: Vec4(0.0, 0.0, 0.0, 1.0) }, optional: TransformableOptional { translation: None, rotation: None, scale: None } } module_name=server_aceclone
15:34:03  INFO ambient::server::wasm: stdout: TransformableOptional default? TransformableOptional { translation: None, rotation: None, scale: None } module_name=server_aceclone

This is unfortunate because it means you need to define lots of redundant optional values. not sure if this was intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant