Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a build so that the artifacts (jars for Android, frameworks for iOS) and their dependencies can be included in another project #2788

Closed
hboon opened this issue Aug 29, 2022 · 5 comments · May be fixed by #2828
Closed

Make a build so that the artifacts (jars for Android, frameworks for iOS) and their dependencies can be included in another project #2788

hboon opened this issue Aug 29, 2022 · 5 comments · May be fixed by #2828
Assignees
@seabornlee
Labels
High Priority
Milestone
Phase 1

Comments

@hboon
Copy link
Member

hboon commented Aug 29, 2022

Details might change, so refer to AlphaWallet/alpha-wallet-ios#5234, at least for now
@seabornlee seabornlee self-assigned this Aug 29, 2022
@seabornlee seabornlee added this to the Phase 1 milestone Aug 29, 2022
@JamesSmartCell
Copy link
Member

A lot of the frameworks like TokenService, TransactionService are deliberately not bound to and UI, so those components should be easy to separate out.

@JamesSmartCell JamesSmartCell mentioned this issue Aug 31, 2022
Closed
2 tasks
@hboon
Copy link
Member Author

hboon commented Aug 31, 2022

Posted in the wrong issue earlier:

POC-style and time, so it's throwaway. But up to you folks if you want to derive permanent improvements from it (modularize etc).

@seabornlee
Copy link
Contributor

seabornlee commented Sep 8, 2022 •
edited

Todo:

  • ECRecover to match the address
  • Publish maven meta data with transitive dependencies
  • Publish .aar to GitHub Package Repository
  • Publish lib module to GPR

@seabornlee seabornlee linked a pull request Sep 20, 2022 that will close this issue
2788 make a build so that the artifacts jars for android frameworks for ios and their dependencies can be included in another project #2828
Draft
@hboon
Copy link
Member Author

hboon commented Oct 10, 2022

@seabornlee think we can close this?

@seabornlee
Copy link
Contributor

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seabornlee seabornlee

Labels
High Priority
Projects
None yet
Milestone
Phase 1
3 participants
@hboon @seabornlee @JamesSmartCell