Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs build is broken #2

Open
NileGraddis opened this issue Jun 18, 2018 · 4 comments
Open

Docs build is broken #2

NileGraddis opened this issue Jun 18, 2018 · 4 comments
Assignees

Comments

@NileGraddis
Copy link
Contributor

sphinx.apidoc was moved to sphinx.ext.apidoc and a reroute was added to cover. This reroute strips out the first element passed to it, which breaks our docs build.

@NileGraddis NileGraddis self-assigned this Jun 18, 2018
@NileGraddis
Copy link
Contributor Author

oh dang, matlab's python bindings are a dependency. I don't actually know much about how those work. @jsiegle how are you guys handling this deployment currently? It might make sense to deploy the matlab python bindings to our internal artifactory server, so that they can be easily installed.

@jsiegle
Copy link
Collaborator

jsiegle commented Jun 19, 2018

So, the spike sorting code is dependent on 3 pieces of "external" software: NpxExtractor, a binary that converts raw data files into arrays of int16s, SpikeBandMedianSubtraction, another binary that removes common-mode noise from the continuous data, and Kilosort2, which does the actual spike sorting. Kilosort2 is what requires the matlab python bindings.

Putting the matlab engine on the artifactory server sounds like a good idea—can you show me how to do that?

What's the best way to make sure the other elements are installed and up-to-date?

@NileGraddis
Copy link
Contributor Author

I don't have read access to those stash repos.

Without knowing how the matlab engine is structured it is difficult to say what would be needed to deploy it to artifactory. Maybe we could sit down and walk through how you guys deploy it on your machines?

@jsiegle
Copy link
Collaborator

jsiegle commented Jun 19, 2018

I just made them public.

The matlab engine comes with the Matlab install, but you have to run setup.py install to use it. The version for R2017a is only compatible with Python 3.5 or lower, so that's something we'll have to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants