Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heartbeat to SDR++ Server protocol #1358

Open
lutusp opened this issue Mar 13, 2024 · 1 comment
Open

Add heartbeat to SDR++ Server protocol #1358

lutusp opened this issue Mar 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@lutusp
Copy link

lutusp commented Mar 13, 2024

This may be taken as a feature request rather than a bug report (it's both), but if a client disconnects from an SDR++ server without first closing the network connection, the server doesn't know it's been orphaned and refuses new connections, then any new clients crash.

One remedy would be to automatically close any active network connection when the user closes the client app (this would free the server). Another would be to prevent the client crash, instead print the connection failure reason on stdout and carry on without crashing. The first remedy is better overall.

Another remedy would be for the client/server connection to use a heartbeat signal to detect active connections, but this is more difficult to implement.

Also ... it's a terrific program. I know, I've written a few myself and this one is much better.

@AlexandreRouma AlexandreRouma added the bug Something isn't working label Mar 25, 2024
@AlexandreRouma
Copy link
Owner

Yeah I'll switch this a to a feature request as the server protocol doesn't have a heartbeat system. This will be taken care of in version 2.0 of the protocol.

@AlexandreRouma AlexandreRouma added enhancement New feature or request and removed bug Something isn't working labels Apr 8, 2024
@AlexandreRouma AlexandreRouma changed the title Server hangs if client connection not explicitly closed Add heartbeat to SDR++ Server protocol Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants