Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Specific video will not play #127

Closed
ner00 opened this issue May 10, 2024 · 5 comments · Fixed by #128
Closed

[BUG] Specific video will not play #127

ner00 opened this issue May 10, 2024 · 5 comments · Fixed by #128
Labels
looking for testers Loogin for testers

Comments

@ner00
Copy link

ner00 commented May 10, 2024

I tried patching FFmpeg 4 and also FFmpeg 6, they both fail to play this particular video. Just for additional context, I tried that other wrapper and the playback for this same video does work with that one, but not with your wrapper. I think the details gathered by your reporting tool should tell you why that is the case, I'm up for testing if needed.

Provide System Details

Describe the bug
The playback never starts, from the report ffmpeg seems to quit early on.

Additional context
Most videos play, but a few like this one don't.

@AlexPresso
Copy link
Owner

Hi ner00,
Thanks for the report, I'll check it out as soon as I have time :)

@AlexPresso
Copy link
Owner

Hi,

The fix is ready, it was already validated with ner0, but for anyone who wants to give it a try just to make sure we don't have any regression, it would be highly appreciated.

To do so, you can unpatch your current installation:

  • curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a unpatch
    And patch using the fixed wrapper:
  • curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a patch -b fix_vaapi

Thank you very much to everyone

@AlexPresso AlexPresso added the looking for testers Loogin for testers label May 14, 2024
@AlexPresso
Copy link
Owner

AlexPresso commented May 18, 2024

Hi @Fabian1601,
Hope you're doing well, sorry to disturb you but by any chance would you have a bit of time to test this patch please ?

[Edit] Sorry other Fabian, wrong ping

@Fabian1601
Copy link

Hello Alex,
I'll try out the script tonight ;)

@Fabian1601
Copy link

Hello Alex,

Now I have more time :-)
I'm fine, hope you are too!
Whenever you do an update of the script I try this out too ;-)
I haven't noticed any negative effects with the current fix.
All videos play and offline transcoding also works.

But my girlfriend found another bug (nothing to do with this one). This one has probably been around for a long time and I suspect it's not related to your script, but maybe you see more than I do ;-)
When I have all the information together I will create a new report.

Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
looking for testers Loogin for testers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants