[1.12.2] JDK 9+ support?

[ghost]

When launching akarin-1.12.2-0.4.2 on jdk 9+ (in my case jdk11) the server will crash.
latest.log
Maybe we could update the mixin to solve the problem?

[dani31c]

Why using Java 8 in 1.12.2 tho?

[dani31c]

Most plugins for 1.12.2 wont work with it

[ghost]

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

[dani31c]

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

[ghost]

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

Supporting jdk 9+ will be backward compatible and you can still run it with jdk 8 if your plugins don't support. Using higher version of jdk will give better gc, jit, and more cpu features.
Actually vanilla and paper are both compiled in java 8 but can also run on jdk 9+ and many plugins are in fact designed for both 1.12- and 1.13+, common plugins designed specifically for 1.12 and java8 actually runs fine with latest java.

[FrostNovaHD]

will try to get support for java 9 and up soonish

[josephworks]

@siyy123 @LegacyGamerHD What is the status on this?

[FrostNovaHD]

@siyy123 @LegacyGamerHD What is the status on this?

not much am prety bussy with life

[josephworks]

Same! No worries!

[ghost]

@siyy123 @LegacyGamerHD What is the status on this?

busy too.
jdk9+ support would be ok if the patch system can work but I do not have time to test :(

[FatSaw]

I tryed launch akarin with mixin 8.3.
And it try to load modlauncher bootstarp:"org.spongepowered.asm.service.modlauncher.MixinServiceModLauncherBootstrap".
I think it should load "org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapperBootstrap" to work with LegacyLauncher.

[FrostNovaHD]

I tryed launch akarin with mixin 8.3. And it try to load modlauncher bootstarp:"org.spongepowered.asm.service.modlauncher.MixinServiceModLauncherBootstrap". I think it should load "org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapperBootstrap" to work with LegacyLauncher.

it s not done yet

[FatSaw]

it s not done yet

I know.

I was building mixin 8.3 for tests and found another possible problem.
paper-api uses "org.ow2.asm" v6._ , mixin 8.3 uses "org.ow2.asm" v7._
it may have dependency conflict.

[FatSaw]

LegacyLauncher has issues working with mixin 8+. I suggest replacing it with ignite: https://github.com/vectrix-space/ignite

[FatSaw]

Experimental version with 8.5 mixin: https://github.com/FatSaw/Akarin/tree/upstream-mixin-EXPERIMENTAL
Built with eclipse.

[FrostNovaHD]

Why not pull request it to us

[FatSaw]

#240 #241