You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of now there's no testing apart from running the src/create_services.sh script, run the code, and check visually the output.
Some more testing is needed to validate changes
Is this a feature you would work on yourself?
I plan to open a pull request for this feature
The text was updated successfully, but these errors were encountered:
I like pytest, so would think it's a good place to start.
I'd probably start by creating the tests directory and just writing that first test, choosing whatever looks not-too-hard to test. That alone would be a good contribution 😄
Writing tests can lead to fairly interactive PRs anyway (where the PR writer asks for opinions of the other contributors, and it goes around several cycles of review) so it makes good sense as a learning task.
Also, trying to write tests for a project that doesn't have them will often lead to refactoring the existing code to make it easier to test, so don't be afraid to raise issues that are like "this part of the code is hard to test, can we refactor it to make it do/not do XXX instead". Refactoring of this type is often a good way of making the code easier to understand as well.
Later on, there's the option of integrating it with the CI toolchain, but initially just having testing set up at all would be great.
What is currently missing?
As of now there's no testing apart from running the
src/create_services.sh
script, run the code, and check visually the output.Some more testing is needed to validate changes
Is this a feature you would work on yourself?
The text was updated successfully, but these errors were encountered: