Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): User is allowed to create nonsensical clusters #2293

Open
mathieu-anderson opened this issue Feb 12, 2024 · 0 comments
Open

fix(core): User is allowed to create nonsensical clusters #2293

mathieu-anderson opened this issue Feb 12, 2024 · 0 comments
Labels
Backend Backend tasks Frontend Relates to coral (react app)

Comments

@mathieu-anderson
Copy link
Contributor

What happened?

There seems to be no validation either in the FE or the BE regarding creation of clusters. This allows users to create nonsensical clusters:

Screen.Recording.2024-02-12.at.09.58.20.mov

However, the biger issue is that users are allowed to create clusters that mostly make sense, but will not work as intended because of a subtle typo or other hard to see issue.

What did you expect to happen?

  • Validation on the front end for superficial errors (typo, formatting ?)
  • Validation on the backend for validity of the cluster that was added (tring to ping it, or a health check, or something?)

The FE fixes may be only implemented on the coral side (#2280), as we may not want to invest too much in the Angular app at this point.

@mathieu-anderson mathieu-anderson added Backend Backend tasks Frontend Relates to coral (react app) labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend tasks Frontend Relates to coral (react app)
Projects
None yet
Development

No branches or pull requests

1 participant