Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(coral/core): The search param in some endpoints matches on data which is not displayed #1821

Open
mathieu-anderson opened this issue Sep 29, 2023 · 0 comments
Labels
Backend Backend tasks bug Something isn't working Frontend Relates to coral (react app)

Comments

@mathieu-anderson
Copy link
Contributor

mathieu-anderson commented Sep 29, 2023

What happened?

In this example, the data displayed in the table after getting the response from /environments/kafka?pageNo=1&searchEnvParam=PR seems incorrect, as the first row doesn't seem to match the search term. However, it does seem to match data that is not displayed in the table:
Screenshot 2023-09-29 at 13 54 02

I haven't tested this throughly, so we need to ascertain that it is really what is happening here. (@aindriu-aiven probably can help)

What did you expect to happen?

The table only displays rows if the data which is rendered matches the search term.

This is a bit of a sticky problem. We can either:

  • render all data that is susceptible to be matched in the table. Problem: this might overload the table with data which is not relevant to the current page
  • do an additional front-end filter on the data returned by the calls with a search param to ensure that only the matching data that is actually rendered is passed to the table component. Problem: bulky, uncomfortable prone to further bugs (if our filtering accidentally filters out something that should not be). And needs to be fixed in many places.
  • another solution I can't think of immediately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend tasks bug Something isn't working Frontend Relates to coral (react app)
Projects
None yet
Development

No branches or pull requests

1 participant